-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instruction to restart Storybook server after addon configuration… #764
Add instruction to restart Storybook server after addon configuration… #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasakiNishi appreciate you taking the time to put together this pull request and helping us improve the tutorial. We appreciate it 🙏
I left a suggestion for you to look into when you have a moment. If you're okay with it, can you apply it to the other versions?
For context, you can check #766 for the wording, and you don't need to apply them to the Svelte version as it's already covered.
Looking forward to hearing from you.
Hope you have a rest of an amazing weekend.
Stay safe
@@ -339,6 +339,12 @@ export default config; | |||
|
|||
``` | |||
|
|||
After updating your Storybook configuration file (`.storybook/main.ts`), restart the Storybook server to apply the new addon configuration and have the UI updated accordingly. Run the following command again: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasakiNishi, we have a bit of room for improvement here and can simplify this to the following:
After updating your Storybook configuration file (`.storybook/main.ts`), restart the Storybook server to apply the new addon configuration and have the UI updated accordingly. Run the following command again: | |
Finally, restart your Storybook to see the new addon enabled in the UI. |
Also, remove the yarn storybook
shell command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonniebigodes, Thank you for the suggested improvements. I have applied them to other versions as well.
Since the changes were also incorporated into the Vue files, I have applied them to only two files.
@MasakiNishi, there is no need to thank you whatsoever; I am glad to help. I appreciate you taking the time to address the feedback. I've checked, and all is good on my end. And going to merge this once the checklist clears. Hope you have a fantastic day. Stay safe |
Overview
This PR adds instructions to the documentation for restarting the Storybook server after updating addon configurations. This ensures users apply the new addon settings and update the UI accordingly.
The corresponding issue
#762