SecuritySerializer: ensure pack separator will not be conflicted with serialized fields #9010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirsa
force-pushed
the
main
branch
2 times, most recently
from
53fc46f
to
01f98fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9010 +/- ##
==========================================
- Coverage 77.81% 77.80% -0.01%
==========================================
Files 150 150
Lines 18689 18682 -7
Branches 3194 3194
==========================================
- Hits 14543 14536 -7
Misses 3854 3854
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thedrow
approved these changes
May 7, 2024
auvipy
reviewed
May 9, 2024
shirsa
force-pushed
the
main
branch
2 times, most recently
from
cfdf81f
to
756c9d6
Compare
|
@auvipy I added a small commit |
auvipy
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
This PR fixes a bug in
SecuritySerializermodule, where the serialized data may contain the value of thesepused to distinguish between the serialized fields. In that case, the fields split will be incorrect and the signature verify will fail.Here, I encode binary values to base64, to prevent the data will contain the separator