feat(beat): add beat shutdown signals #8551
Open
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8551 +/- ##
==========================================
- Coverage 77.81% 77.80% -0.01%
==========================================
Files 150 150
Lines 18688 18692 +4
Branches 3194 3194
==========================================
+ Hits 14542 14544 +2
- Misses 3854 3856 +2
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
noirbizarre
force-pushed
the
beat/shutdown-signals
branch
from
1da201c
to
1133ae6
Compare
auvipy
requested changes
Oct 4, 2023
| @@ -656,6 +656,25 @@ beat` is started as an embedded process. | |||
|
|
|||
| Sender is the :class:`celery.beat.Service` instance. | |||
|
|
|||
| .. signal:: beat_shutting_down | |||
|
|
|||
| ``beat_shutting_down`` | |||
There was a problem hiding this comment.
can we think about better naming? also it would be nice to have some more context about when and why this should be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a very quick addition: it provides shutdown signals to
beatusing the same convention as the worker:signals.beat_shutting_downdispatched when the beat process is starting its shutdownsignals.beat_shutdowndispatched when the beat process has completed its shutdownNote: there was no existing test on dispatched signals so I added one testing those lifecycle signals