Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply task upon eager retry #8367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewdieken
Copy link

This PR will be merged into branch main.

Description

This PR updates the retry methods eager logic of the Task class ensuring apply is called on the created Signature object.

Fixes #8056

@andrewdieken
Copy link
Author

@auvipy this change broke quite a few tests within the test_task_retries test class 😠 started to track down the issue(s) but ran out of time. Will continue to work through the failures but wanted to get the PR opened so you could get 👀 on it

@auvipy
Copy link
Member

auvipy commented Jul 11, 2023

it seems you didn't pick all the needed parts here. you can check the old pr

@djanowski
Copy link

Hi! Any updates here? I can't test the retry logic without this change. Thank you!

@andrewdieken
Copy link
Author

Hi! Any updates here? I can't test the retry logic without this change. Thank you!

Unfortunately, I haven't put any more time into this. I appreciate and welcome any support on this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 2.2 + Celery 5.2.7 unit testing does not Retrying the task
3 participants