result_backend_thread_safe config shares backend across threads #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.00% // Head: 87.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8058 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 148 148
Lines 18486 18496 +10
Branches 2520 2523 +3
=======================================
+ Hits 16083 16093 +10
Misses 2123 2123
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Feb 7, 2023
auvipy
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #6819
This aims to allow users to opt-in to sharing the backend object across threads if the backend is thread safe. Other attempts have been made to do this such as #7961. However, there seemed to be uncertainty with whether to move forward with those or not. I figure allowing this be a configuration lets users switch back if they notice issues.