Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: API Build cache in CI pipeline #14929

Merged

Conversation

utkershrajvenshi
Copy link
Contributor

What does this PR do?

Added cache retrieval steps for api v1 and api v2 in production builds github workflow run

Fixes #14921

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented May 7, 2024

@utkershrajvenshi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team May 7, 2024 21:10
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 7, 2024
@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth ci area: CI, DX, pipeline, github actions Low priority Created by Linear-GitHub Sync labels May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented May 7, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/07/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented May 7, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode requested review from a team and removed request for a team May 7, 2024 21:40
@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! Had one question for you

key-4: ${{ github.sha }}
with:
path: |
${{ github.workspace }}/apps/api/v2/.next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 is not a Next.js app but rather a NestJS app. What was the intention of this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be an oversight from my end. Sorry about that.

One thing I would like to run by you is that while running build command for api/v2 the build was stored in ./dist folder. So should this and **/.turbo/** be even required to pass under path?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so. Think we should be good with the dist line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! I'll make the relevant changes 🙏

@utkershrajvenshi
Copy link
Contributor Author

Hi @keithwillcode , are there any other changes to be done for this PR?

@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging and will test on our main.

@keithwillcode keithwillcode enabled auto-merge (squash) May 17, 2024 21:59
@keithwillcode keithwillcode merged commit 2714368 into calcom:main May 17, 2024
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth ci area: CI, DX, pipeline, github actions community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3655] Add API build cache in CI pipeline
2 participants