New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: API Build cache in CI pipeline #14929
chore: API Build cache in CI pipeline #14929
Conversation
@utkershrajvenshi is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (05/07/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR! Had one question for you
key-4: ${{ github.sha }} | ||
with: | ||
path: | | ||
${{ github.workspace }}/apps/api/v2/.next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 is not a Next.js app but rather a NestJS app. What was the intention of this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to be an oversight from my end. Sorry about that.
One thing I would like to run by you is that while running build
command for api/v2 the build was stored in ./dist
folder. So should this and **/.turbo/**
be even required to pass under path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. Think we should be good with the dist
line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! I'll make the relevant changes 🙏
Hi @keithwillcode , are there any other changes to be done for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging and will test on our main.
What does this PR do?
Added cache retrieval steps for api v1 and api v2 in production builds github workflow run
Fixes #14921
Type of change
Mandatory Tasks
Checklist