Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: orgs create dynamic events from org member list #14912

Merged
merged 9 commits into from May 10, 2024

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented May 7, 2024

Fixes #14519
Fixes CAL-3399

CleanShot 2024-05-07 at 10 41 40
CleanShot 2024-05-07 at 10 41 43

Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 0:54am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 0:54am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 0:54am

@github-actions github-actions bot added enterprise area: enterprise, audit log, organisation, SAML, SSO event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync organizations area: organizations, orgs ✨ feature New feature or request 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup labels May 7, 2024
Copy link

linear bot commented May 7, 2024

Copy link
Contributor

github-actions bot commented May 7, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/availability 427.64 KB 656.27 KB 187.50% (🟢 -10.67%)
/settings/admin/lockedSMS/UsersTable 79.5 KB 308.13 KB 88.04% (🟡 +0.17%)
/settings/admin/lockedSMS/lockedSMSView 119.27 KB 347.9 KB 99.40% (🟡 +0.20%)
/settings/admin/oAuth/oAuthView 95.65 KB 324.28 KB 92.65% (🟡 +0.20%)
/settings/organizations/dsync 294.59 KB 523.22 KB 149.49% (🟢 -10.61%)
/settings/organizations/members 399.95 KB 628.57 KB 179.59% (🟢 -8.82%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@sean-brydon sean-brydon marked this pull request as ready for review May 7, 2024 09:59
@graphite-app graphite-app bot requested a review from a team May 7, 2024 09:59
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label May 7, 2024
Copy link

graphite-app bot commented May 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

deploysentinel bot commented May 7, 2024

Current Playwright Test Results Summary

✅ 320 Passing - ⚠️ 17 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/10/2024 01:05:01pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 6682fa6

Started: 05/10/2024 01:02:00pm UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
3.99% (12) 12 / 301 runs
failed over last 7 days
19.27% (58) 58 / 301 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 2Retry 1Initial Attempt
8.72% (26) 26 / 298 runs
failed over last 7 days
26.85% (80) 80 / 298 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1Initial Attempt
0% (0) 0 / 260 runs
failed over last 7 days
35.77% (93) 93 / 260 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0.98% (3) 3 / 305 runs
failed over last 7 days
17.38% (53) 53 / 305 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to Org
Retry 1Initial Attempt
0.34% (1) 1 / 292 run
failed over last 7 days
2.40% (7) 7 / 292 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
3.03% (9) 9 / 297 runs
failed over last 7 days
29.29% (87) 87 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (verified)
Retry 1Initial Attempt
0.99% (3) 3 / 303 runs
failed over last 7 days
5.61% (17) 17 / 303 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

null

9 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
3.41% (10) 10 / 293 runs
failed over last 7 days
55.63% (163) 163 / 293 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-135.83% (-163) -163 / 120 runs
failed over last 7 days
135.83% (163) 163 / 120 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-134.17% (-161) -161 / 120 runs
failed over last 7 days
134.17% (161) 161 / 120 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-135.83% (-163) -163 / 120 runs
failed over last 7 days
135.83% (163) 163 / 120 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-134.17% (-161) -161 / 120 runs
failed over last 7 days
134.17% (161) 161 / 120 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-134.17% (-161) -161 / 120 runs
failed over last 7 days
134.17% (161) 161 / 120 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-134.17% (-161) -161 / 120 runs
failed over last 7 days
134.17% (161) 161 / 120 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-134.17% (-161) -161 / 120 runs
failed over last 7 days
134.17% (161) 161 / 120 runs
flaked over last 7 days
Popup Tests should open on clicking child element
Retry 1Initial Attempt
-130.83% (-157) -157 / 120 runs
failed over last 7 days
130.83% (157) 157 / 120 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
13.10% (44) 44 / 336 runs
failed over last 7 days
28.27% (95) 95 / 336 runs
flaked over last 7 days

View Detailed Build Results


@Udit-takkar Udit-takkar changed the title Orgs: create dynamic events from org member list feat: orgs create dynamic events from org member list May 7, 2024
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: displays three avatar on two people dynamic links

Screen.Recording.2024-05-07.at.3.58.08.PM.mov

@sean-brydon
Copy link
Member Author

NIT: displays three avatar on two people dynamic links

Screen.Recording.2024-05-07.at.3.58.08.PM.mov

I dont think this is related to this PR - all i've done here is create a way to open this booker. Correct me if im mistaken tho

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Udit-takkar Udit-takkar enabled auto-merge (squash) May 10, 2024 12:52
@Udit-takkar Udit-takkar merged commit 83e15c4 into main May 10, 2024
40 checks passed
@Udit-takkar Udit-takkar deleted the feat/dynamic-events-from-org-list-cal-33999 branch May 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO event-types area: event types, event-types ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup organizations area: organizations, orgs ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3399] Orgs: create dynamic events from org member list
4 participants