Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed email embed for team when specific times are chosen embeds the wrong URL #14889

Closed
wants to merge 3 commits into from
Closed

fix: Fixed email embed for team when specific times are chosen embeds the wrong URL #14889

wants to merge 3 commits into from

Conversation

vikrant845
Copy link
Contributor

What does this PR do?

Fixes #14259

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Set up a Team and add availability
  2. Go to team event and click the Embed button
  3. Click on Email embed
  4. Choose specific times to embed
  5. Paste into the email
  6. When clicking on each of the selected times, they go to the correct page.

Mandatory Tasks

  • [*] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel Vercel
Copy link

vercel bot commented May 6, 2024

@borawakevikrant is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team May 6, 2024 09:14
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 6, 2024
@graphite-app graphite-app bot requested a review from a team May 6, 2024 09:14
@CLAassistant
Copy link

CLAassistant commented May 6, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added embed area: embed, widget, react embed teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels May 6, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 6, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/06/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (05/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@socket-security Socket Security
Copy link

socket-security bot commented May 6, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@16.9.1 None 0 1.63 MB types
npm/@types/react@18.0.26 None 0 178 kB types
npm/prisma@5.13.0 environment 0 11.7 MB prismabot
npm/rrule@2.8.1 None 0 687 kB davidgoli
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/@aashutoshrathi/word-wrap@1.2.6, npm/@adobe/css-tools@4.3.3, npm/@ampproject/remapping@2.2.1, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-validator-option@7.23.5, npm/@emotion/sheet@1.2.2, npm/@emotion/unitless@0.8.1, npm/@emotion/use-insertion-effect-with-fallbacks@1.0.1, npm/@emotion/utils@1.2.1, npm/@esbuild/android-arm64@0.20.2, npm/@esbuild/android-arm@0.20.2, npm/@esbuild/android-x64@0.20.2, npm/@esbuild/darwin-arm64@0.20.2, npm/@esbuild/darwin-x64@0.20.2, npm/@esbuild/freebsd-arm64@0.20.2, npm/@esbuild/freebsd-x64@0.20.2, npm/@esbuild/linux-arm64@0.20.2, npm/@esbuild/linux-arm@0.20.2, npm/@esbuild/linux-ia32@0.20.2, npm/@esbuild/linux-loong64@0.20.2, npm/@esbuild/linux-mips64el@0.20.2, npm/@esbuild/linux-ppc64@0.20.2, npm/@esbuild/linux-riscv64@0.20.2, npm/@esbuild/linux-s390x@0.20.2, npm/@esbuild/linux-x64@0.20.2, npm/@esbuild/netbsd-x64@0.20.2, npm/@esbuild/openbsd-x64@0.20.2, npm/@esbuild/sunos-x64@0.20.2, npm/@esbuild/win32-arm64@0.20.2, npm/@esbuild/win32-ia32@0.20.2, npm/@esbuild/win32-x64@0.20.2, npm/@eslint-community/eslint-utils@4.4.0, npm/@eslint-community/regexpp@4.10.0, npm/@eslint/js@8.57.0, npm/@humanwhocodes/config-array@0.11.14, npm/@humanwhocodes/module-importer@1.0.1, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@nodelib/fs.scandir@2.1.5, npm/@nodelib/fs.stat@2.0.5, npm/@nodelib/fs.walk@1.2.8, npm/@pkgjs/parseargs@0.11.0, npm/@reach/observe-rect@1.2.0, npm/@rollup/pluginutils@5.1.0, npm/@types/babel__core@7.20.5, npm/@types/babel__generator@7.6.8, npm/@types/babel__template@7.4.4, npm/@types/babel__traverse@7.20.5, npm/@types/d3-array@3.2.1, npm/@types/d3-color@3.1.3, npm/@types/d3-ease@3.0.2, npm/@types/d3-interpolate@3.0.4, npm/@types/d3-scale@4.0.8, npm/@types/d3-shape@3.1.6, npm/@types/d3-time@3.0.3, npm/@types/d3-timer@3.0.2, npm/@types/estree@1.0.5, npm/@types/json-schema@7.0.15, npm/@types/luxon@3.4.2, npm/@types/mdast@3.0.15, npm/@types/minimist@1.2.5, npm/@types/normalize-package-data@2.4.4, npm/@types/parse-json@4.0.2, npm/@types/unist@2.0.10, npm/@ungap/structured-clone@1.2.0, npm/acorn-jsx@5.3.2, npm/agent-base@6.0.2, npm/ansi-regex@6.0.1, npm/anymatch@3.1.3, npm/argparse@2.0.1, npm/array-union@2.1.0, npm/arrify@1.0.1, npm/async@3.2.5, npm/balanced-match@1.0.2, npm/base64-js@1.5.1, npm/bignumber.js@9.1.2, npm/boolbase@1.0.0, npm/brace-expansion@2.0.1, npm/braces@3.0.2, npm/buffer-equal-constant-time@1.0.1, npm/builtin-modules@3.3.0, npm/callsites@3.1.0, npm/camelcase-keys@6.2.2, npm/camelcase@5.3.1, npm/character-entities-legacy@1.1.4, npm/character-entities@1.2.4, npm/character-reference-invalid@1.1.4, npm/color-name@1.1.3, npm/concat-map@0.0.1, npm/convert-source-map@2.0.0, npm/cross-spawn@7.0.3, npm/css-what@6.1.0, npm/cssesc@3.0.0, npm/csstype@3.1.3, npm/d3-array@3.2.4, npm/d3-color@3.1.0, npm/d3-ease@3.0.1, npm/d3-format@3.1.0, npm/d3-interpolate@3.0.1, npm/d3-path@3.1.0, npm/d3-scale@4.0.2, npm/d3-shape@3.2.0, npm/d3-time-format@4.1.0, npm/d3-time@3.1.0, npm/d3-timer@3.0.1, npm/date-fns@2.30.0, npm/debug@4.3.4, npm/decamelize-keys@1.1.1, npm/decamelize@1.2.0, npm/decimal.js-light@2.5.1, npm/deep-is@0.1.4, npm/detect-element-overflow@1.4.2, npm/dir-glob@3.0.1, npm/doctrine@3.0.0, npm/dom-helpers@5.2.1, npm/domelementtype@2.3.0, npm/domhandler@5.0.3, npm/eastasianwidth@0.2.0, npm/ecdsa-sig-formatter@1.0.11, npm/emoji-regex@9.2.2, npm/entities@4.5.0, npm/error-ex@1.3.2, npm/escape-string-regexp@1.0.5, npm/eslint-scope@7.2.2, npm/eslint-visitor-keys@3.4.3, npm/esquery@1.5.0, npm/esrecurse@4.3.0, npm/estraverse@5.3.0, npm/estree-walker@2.0.2, npm/esutils@2.0.3, npm/eventemitter3@4.0.7, npm/extend@3.0.2, npm/fast-deep-equal@3.1.3, npm/fast-equals@5.0.1, npm/fast-glob@3.3.2, npm/fast-json-stable-stringify@2.1.0, npm/file-entry-cache@6.0.1, npm/fill-range@7.0.1, npm/find-root@1.1.0, npm/flat-cache@3.2.0, npm/flatted@3.3.1, npm/fraction.js@4.3.7, npm/fs.realpath@1.0.0, npm/fsevents@2.3.3, npm/function-bind@1.1.2, npm/gcp-metadata@6.1.0, npm/gensync@1.0.0-beta.2, npm/get-caller-file@2.0.5, npm/glob-parent@6.0.2, npm/globals@13.24.0, npm/globby@11.1.0, npm/gopd@1.0.1, npm/graphemer@1.4.0, npm/hard-rejection@2.1.0, npm/has-flag@3.0.0, npm/has-symbols@1.0.3, npm/hosted-git-info@2.8.9, npm/human-signals@2.1.0, npm/husky@8.0.3, npm/import-fresh@3.3.0, npm/imurmurhash@0.1.4, npm/indent-string@4.0.0, npm/inflight@1.0.6, npm/inherits@2.0.4, npm/ini@1.3.8, npm/internmap@2.0.3, npm/invariant@2.2.4, npm/is-arrayish@0.2.1, npm/is-binary-path@2.1.0, npm/is-builtin-module@3.2.1, npm/is-core-module@2.13.1, npm/is-extglob@2.1.1, npm/is-glob@4.0.3, npm/is-number@7.0.0, npm/is-obj@2.0.0, npm/is-path-inside@3.0.3, npm/is-plain-obj@1.1.0, npm/isexe@2.0.0, npm/jackspeak@2.3.6, npm/jiti@1.21.0, npm/js-tokens@4.0.0, npm/jsesc@2.5.2, npm/json-bigint@1.0.0, npm/json-buffer@3.0.1, npm/json-parse-even-better-errors@2.3.1, npm/json-schema-traverse@1.0.0, npm/json-stable-stringify-without-jsonify@1.0.1, npm/json5@2.2.3, npm/keyv@4.5.4, npm/kind-of@6.0.3, npm/kleur@3.0.3, npm/levn@0.4.1, npm/lines-and-columns@1.2.4, npm/lodash.camelcase@4.3.0, npm/lodash.isplainobject@4.0.6, npm/lodash.memoize@4.1.2, npm/lodash.merge@4.6.2, npm/lodash.startcase@4.4.0, npm/lodash@4.17.21, npm/loose-envify@1.4.0, npm/make-event-props@1.6.2, npm/map-obj@4.3.0, npm/merge-stream@2.0.0, npm/merge2@1.4.1, npm/micromatch@4.0.5, npm/min-indent@1.0.1, npm/minimist-options@4.1.0, npm/minimist@1.2.8, npm/ms@2.1.2, npm/nanoid@3.3.7, npm/natural-compare-lite@1.4.0, npm/natural-compare@1.4.0, npm/node-releases@2.0.14, npm/normalize-path@3.0.0, npm/normalize-range@0.1.2, npm/npm-run-path@4.0.1, npm/nth-check@2.1.1, npm/object-assign@4.1.1, npm/object-inspect@1.13.1, npm/once@1.4.0, npm/onetime@5.1.2, npm/p-limit@2.3.0, npm/p-try@2.2.0, npm/parent-module@1.0.1, npm/path-exists@4.0.0, npm/path-is-absolute@1.0.1, npm/path-key@3.1.1, npm/path-parse@1.0.7, npm/path-type@4.0.0, npm/pathe@1.1.2, npm/picocolors@1.0.0, npm/picomatch@2.3.1, npm/pluralize@8.0.0, npm/postcss-value-parser@4.2.0, npm/prelude-ls@1.2.1, npm/progress@2.0.3, npm/prompts@2.4.2, npm/proxy-from-env@1.1.0, npm/punycode@2.3.1, npm/queue-microtask@1.2.3, npm/quick-lru@4.0.1, npm/react-fit@1.7.1, npm/react-transition-group@4.4.5, npm/readable-stream@3.6.2, npm/readdirp@3.6.0, npm/recharts-scale@0.4.5, npm/redent@3.0.0, npm/regenerator-runtime@0.14.1, npm/require-directory@2.1.1, npm/require-from-string@2.0.2, npm/resolve-from@5.0.0, npm/resolve@1.22.8, npm/reusify@1.0.4, npm/rimraf@3.0.2, npm/run-parallel@1.2.0, npm/rxjs@7.8.1, npm/safe-buffer@5.2.1, npm/sax@1.3.0, npm/shell-quote@1.8.1, npm/sisteransi@1.0.5, npm/slash@3.0.0, npm/source-map-js@1.2.0, npm/source-map@0.6.1, npm/spawn-command@0.0.2, npm/spdx-expression-parse@3.0.1, npm/split2@3.2.2, npm/string_decoder@1.3.0, npm/strip-ansi@6.0.1, npm/strip-final-newline@2.0.0, npm/strip-indent@3.0.0, npm/strip-json-comments@3.1.1, npm/supports-preserve-symlinks-flag@1.0.0, npm/text-table@0.2.0, npm/through@2.3.8, npm/tiny-warning@1.0.3, npm/to-fast-properties@2.0.0, npm/to-regex-range@5.0.1, npm/tr46@0.0.3, npm/tree-kill@1.2.2, npm/trim-newlines@3.0.1, npm/tslib@2.6.2, npm/type-check@0.4.0, npm/update-input-width@1.4.2, npm/uri-js@4.4.1, npm/url-template@2.0.8, npm/util-deprecate@1.0.2, npm/webpack-sources@3.2.3, npm/webpack-virtual-modules@0.6.1, npm/which@2.0.2, npm/wrappy@1.0.2, npm/xml-name-validator@4.0.0, npm/y18n@5.0.8, npm/yallist@4.0.0, npm/yaml@1.10.2, npm/yargs-parser@20.2.9, npm/yocto-queue@0.1.0

View full report↗︎

@vikrant845 vikrant845 changed the title Fix #14259 fix: Fixed email embed for team when specific times are chosen embeds the wrong URL May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Hundred Twenty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 96.85 KB 325.84 KB 93.10% (🟡 +0.39%)
/500 91.83 KB 320.82 KB 91.66% (🟡 +0.45%)
/[user] 109.99 KB 338.98 KB 96.85% (🟡 +0.77%)
/[user]/[type] 394.48 KB 623.47 KB 178.13% (🟢 -5.04%)
/[user]/[type]/embed 394.48 KB 623.47 KB 178.13% (🟢 -5.03%)
/[user]/embed 109.99 KB 338.98 KB 96.85% (🟡 +0.77%)
/apps 287.92 KB 516.91 KB 147.69% (🟡 +2.64%)
/apps/[slug] 305.49 KB 534.48 KB 152.71% (🟡 +2.66%)
/apps/[slug]/[...pages] 563.61 KB 792.6 KB 226.46% (🟢 -6.67%)
/apps/[slug]/setup 88.07 KB 317.06 KB 90.59% (🟡 +0.40%)
/apps/categories 265.68 KB 494.67 KB 141.33% (🟡 +2.65%)
/apps/categories/[category] 270 KB 498.99 KB 142.57% (🟡 +2.64%)
/apps/installed/[category] 289.17 KB 518.16 KB 148.05% (🟡 +2.63%)
/auth/error 102.64 KB 331.63 KB 94.75% (🟡 +0.74%)
/auth/forgot-password 104.08 KB 333.07 KB 95.16% (🟡 +0.60%)
/auth/forgot-password/[id] 107.78 KB 336.77 KB 96.22% (🟡 +0.63%)
/auth/login 121.29 KB 350.28 KB 100.08% (🟡 +0.91%)
/auth/logout 88.8 KB 317.79 KB 90.80% (🟡 +0.42%)
/auth/platform/authorize 88.68 KB 317.67 KB 90.76% (🟡 +0.41%)
/auth/saml-idp 86.23 KB 315.22 KB 90.06% (🟡 +0.41%)
/auth/setup 152.75 KB 381.74 KB 109.07% (🟡 +1.03%)
/auth/signin 86.32 KB 315.31 KB 90.09% (🟡 +0.41%)
/auth/sso/[provider] 86.35 KB 315.34 KB 90.10% (🟡 +0.41%)
/auth/sso/direct 86.26 KB 315.25 KB 90.07% (🟡 +0.41%)
/auth/verify 147 KB 375.99 KB 107.43% (🟡 +1.03%)
/auth/verify-email 91.73 KB 320.72 KB 91.63% (🟡 +0.45%)
/auth/verify-email-change 91.51 KB 320.5 KB 91.57% (🟡 +0.45%)
/availability 445.26 KB 674.25 KB 192.64% (🟢 -5.56%)
/availability/[schedule] 389.16 KB 618.15 KB 176.61% (🟢 -6.27%)
/availability/troubleshoot 87.94 KB 316.93 KB 90.55% (🟡 +0.41%)
/booking/[uid] 228.78 KB 457.77 KB 130.79% (🟡 +0.75%)
/booking/[uid]/embed 228.79 KB 457.78 KB 130.79% (🟡 +0.75%)
/bookings/[status] 333.42 KB 562.41 KB 160.69% (🟡 +2.62%)
/connect-and-join 88.46 KB 317.45 KB 90.70% (🟡 +0.42%)
/d/[link]/[slug] 394.29 KB 623.28 KB 178.08% (🟢 -5.04%)
/enterprise 265.73 KB 494.72 KB 141.35% (🟡 +2.65%)
/event-types 533.31 KB 762.3 KB 217.80% (🟢 -6.54%)
/event-types/[type] 411.42 KB 640.41 KB 182.97% (🟢 -6.91%)
/getting-started/[[...step]] 376.61 KB 605.6 KB 173.03% (🟢 -7.98%)
/insights 436.22 KB 665.21 KB 190.06% (🟢 -11.19%)
/maintenance 31.38 KB 260.37 KB 74.39% (🟡 +0.23%)
/more 265.24 KB 494.23 KB 141.21% (🟡 +2.65%)
/org/[orgSlug] 269.77 KB 498.76 KB 142.50% (🟡 +1.34%)
/org/[orgSlug]/[user] 275.94 KB 504.93 KB 144.27% (🟡 +1.36%)
/org/[orgSlug]/[user]/[type] 394.67 KB 623.67 KB 178.19% (🟢 -5.04%)
/org/[orgSlug]/[user]/[type]/embed 394.7 KB 623.69 KB 178.20% (🟢 -5.04%)
/org/[orgSlug]/[user]/embed 275.97 KB 504.96 KB 144.27% (🟡 +1.37%)
/org/[orgSlug]/embed 269.79 KB 498.78 KB 142.51% (🟡 +1.33%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 394.3 KB 623.29 KB 178.08% (🟢 -5.03%)
/org/[orgSlug]/team/[slug] 269.78 KB 498.77 KB 142.51% (🟡 +1.33%)
/org/[orgSlug]/team/[slug]/[type] 394.5 KB 623.49 KB 178.14% (🟢 -5.04%)
/payment/[uid] 121.61 KB 350.6 KB 100.17% (🟡 +0.55%)
/settings/admin 271.32 KB 500.31 KB 142.95% (🟡 +2.64%)
/settings/admin/apps 284.41 KB 513.4 KB 146.68% (🟡 +2.63%)
/settings/admin/apps/[category] 284.39 KB 513.38 KB 146.68% (🟡 +2.63%)
/settings/admin/flags 275.43 KB 504.42 KB 144.12% (🟡 +2.64%)
/settings/admin/impersonation 271.68 KB 500.67 KB 143.05% (🟡 +2.61%)
/settings/admin/lockedSMS 292.53 KB 521.52 KB 149.00% (🟡 +2.66%)
/settings/admin/lockedSMS/UsersTable 81.19 KB 310.18 KB 88.62% (🟡 +0.66%)
/settings/admin/lockedSMS/lockedSMSView 122.2 KB 351.19 KB 100.34% (🟡 +1.04%)
/settings/admin/oAuth 283.48 KB 512.47 KB 146.42% (🟡 +2.64%)
/settings/admin/oAuth/oAuthView 97.47 KB 326.46 KB 93.27% (🟡 +0.72%)
/settings/admin/orgMigrations/_OrgMigrationLayout 259.83 KB 488.82 KB 139.66% (🟡 +2.65%)
/settings/admin/orgMigrations/moveTeamToOrg 309.33 KB 538.32 KB 153.81% (🟡 +2.62%)
/settings/admin/orgMigrations/moveUserToOrg 328.79 KB 557.78 KB 159.36% (🟡 +2.65%)
/settings/admin/orgMigrations/removeTeamFromOrg 309.08 KB 538.07 KB 153.73% (🟡 +2.63%)
/settings/admin/orgMigrations/removeUserFromOrg 309.09 KB 538.08 KB 153.74% (🟡 +2.62%)
/settings/admin/organizations 272.89 KB 501.88 KB 143.39% (🟡 +2.65%)
/settings/admin/organizations/[id]/edit 271.7 KB 500.69 KB 143.06% (🟡 +2.64%)
/settings/admin/users 273.57 KB 502.56 KB 143.59% (🟡 +2.64%)
/settings/admin/users/[id]/edit 371.18 KB 600.17 KB 171.48% (🟢 -6.24%)
/settings/admin/users/add 370.91 KB 599.9 KB 171.40% (🟢 -6.23%)
/settings/billing 271.43 KB 500.42 KB 142.98% (🟡 +2.64%)
/settings/developer/api-keys 275.48 KB 504.47 KB 144.13% (🟡 +2.65%)
/settings/developer/webhooks 275.55 KB 504.54 KB 144.16% (🟡 +2.64%)
/settings/developer/webhooks/[id] 276.57 KB 505.56 KB 144.45% (🟡 +2.64%)
/settings/developer/webhooks/new 276.57 KB 505.56 KB 144.44% (🟡 +2.65%)
/settings/my-account/appearance 324.22 KB 553.21 KB 158.06% (🟡 +2.62%)
/settings/my-account/calendars 281.96 KB 510.95 KB 145.99% (🟡 +2.63%)
/settings/my-account/conferencing 283.23 KB 512.22 KB 146.35% (🟡 +2.63%)
/settings/my-account/general 358.06 KB 587.05 KB 167.73% (🟢 -5.69%)
/settings/my-account/out-of-office 276.1 KB 505.09 KB 144.31% (🟡 +2.64%)
/settings/my-account/profile 415.43 KB 644.42 KB 184.12% (🟡 +2.84%)
/settings/organizations/[id]/about 159.35 KB 388.34 KB 110.95% (🟡 +1.04%)
/settings/organizations/[id]/add-teams 159.34 KB 388.33 KB 110.95% (🟡 +1.04%)
/settings/organizations/[id]/onboard-members 174.06 KB 403.05 KB 115.16% (🟡 +0.68%)
/settings/organizations/appearance 295.38 KB 524.37 KB 149.82% (🟡 +2.64%)
/settings/organizations/billing 271.51 KB 500.5 KB 143.00% (🟡 +2.64%)
/settings/organizations/dsync 343.19 KB 572.18 KB 163.48% (🟡 +3.35%)
/settings/organizations/general 328.17 KB 557.16 KB 159.19% (🟢 -6.22%)
/settings/organizations/members 411.27 KB 640.26 KB 182.93% (🟢 -5.51%)
/settings/organizations/new 159.36 KB 388.35 KB 110.96% (🟡 +1.03%)
/settings/organizations/platform/oauth-clients 274 KB 502.99 KB 143.71% (🟡 +2.65%)
/settings/organizations/platform/oauth-clients/create 274.18 KB 503.17 KB 143.76% (🟡 +2.65%)
/settings/organizations/privacy 277.09 KB 506.08 KB 144.60% (🟡 +2.64%)
/settings/organizations/profile 408.33 KB 637.32 KB 182.09% (🟡 +2.88%)
/settings/organizations/sso 282.17 KB 511.16 KB 146.05% (🟡 +2.64%)
/settings/organizations/teams/other 272.07 KB 501.06 KB 143.16% (🟡 +2.64%)
/settings/organizations/teams/other/[id]/appearance 284.21 KB 513.21 KB 146.63% (🟡 +2.64%)
/settings/organizations/teams/other/[id]/members 279.16 KB 508.15 KB 145.19% (🟡 +2.64%)
/settings/organizations/teams/other/[id]/profile 480.86 KB 709.85 KB 202.81% (🟡 +3.49%)
/settings/security/impersonation 276.33 KB 505.32 KB 144.38% (🟡 +2.64%)
/settings/security/password 313.83 KB 542.82 KB 155.09% (🟡 +2.63%)
/settings/security/sso 281.5 KB 510.49 KB 145.85% (🟡 +2.65%)
/settings/security/two-factor-auth 279.75 KB 508.75 KB 145.36% (🟡 +2.64%)
/settings/teams 270.99 KB 499.98 KB 142.85% (🟡 +2.64%)
/settings/teams/[id]/appearance 284.2 KB 513.19 KB 146.63% (🟡 +2.64%)
/settings/teams/[id]/billing 271.51 KB 500.5 KB 143.00% (🟡 +2.64%)
/settings/teams/[id]/members 359.94 KB 588.93 KB 168.26% (🟢 -5.71%)
/settings/teams/[id]/onboard-members 173.24 KB 402.23 KB 114.92% (🟡 +0.69%)
/settings/teams/[id]/profile 481.69 KB 710.68 KB 203.05% (🟡 +3.49%)
/settings/teams/new 201.51 KB 430.5 KB 123.00% (🟡 +0.91%)
/signup 181.01 KB 410 KB 117.14% (🟡 +0.93%)
/team/[slug] 269.7 KB 498.69 KB 142.48% (🟡 +1.34%)
/team/[slug]/[type] 394.46 KB 623.46 KB 178.13% (🟢 -5.04%)
/team/[slug]/[type]/embed 394.49 KB 623.48 KB 178.14% (🟢 -5.04%)
/team/[slug]/embed 269.77 KB 498.76 KB 142.50% (🟡 +1.34%)
/teams 265.46 KB 494.46 KB 141.27% (🟡 +2.65%)
/upgrade 265.59 KB 494.58 KB 141.31% (🟡 +2.64%)
/video/[uid] 299.59 KB 528.58 KB 151.02% (🟡 +1.08%)
/video/meeting-ended/[uid] 96.98 KB 325.97 KB 93.13% (🟡 +0.41%)
/video/meeting-not-started/[uid] 96.62 KB 325.61 KB 93.03% (🟡 +0.41%)
/video/no-meeting-found 87.43 KB 316.42 KB 90.41% (🟡 +0.41%)
/workflows 296.98 KB 525.97 KB 150.28% (🟡 +2.66%)
/workflows/[workflow] 420.1 KB 649.09 KB 185.45% (🟡 +2.86%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@socket-security Socket Security
Copy link

socket-security bot commented May 6, 2024 •
edited

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/prisma@5.13.0
  • Install script: preinstall
  • Source: node scripts/preinstall-entry.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/prisma@5.13.0

@vikrant845 vikrant845 mentioned this pull request May 8, 2024
Closed
@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
CarinaWolli
CarinaWolli requested changes May 8, 2024
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good, but yarn.lock changes need to be removed first 🙏

yarn.lock Outdated
@@ -5,46 +5,6 @@ __metadata:
version: 6
cacheKey: 8

"@0no-co/graphql.web@npm:^1.0.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is a guide on how to remove the changes form yarn.lock: https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md#guidelines-for-committing-yarn-lockfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Deleted the yarn.lock file. Please check.
PR: #14889

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md#guidelines-for-committing-yarn-lockfile

This fix wasn't working for me, the yarn.lock changes were not reverting. That's why I had to delete the yarn.lock file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed this one and opened a new PR #14975.

@vikrant845 vikrant845 closed this May 10, 2024
@dosubot dosubot bot removed this from the v4.1 milestone May 10, 2024
@vikrant845
Copy link
Contributor Author

Closed due to yarn.lock issues.
Opened a new one #14975 solving the issue.

@vikrant845 vikrant845 deleted the fix/embeds-wrong-team-url branch May 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli requested changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync embed area: embed, widget, react embed teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email embed for team when specific times are chosen embeds the wrong URL
5 participants
@vikrant845 @CLAassistant @CarinaWolli @keithwillcode @borawakevikrant