feat: go to Assignment tab after creation and warn if existing without assigning #14882
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
event-types
anikdhabal
changed the title
Graphite Automations"Add community label" took an action on this PR • (05/05/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/05/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
packages/features/eventtypes/components/CreateEventTypeDialog.tsx
Outdated
Show resolved
Hide resolved
|
@supalarry @Udit-takkar thanks for your reviews. |
It should only throw this modal when you go to leave the entire event type, not a tab within the event type. |
There was a problem hiding this comment.
Marking as requested changes so we can address @ciaranha's comment about the tab versus page.
|
@keithwillcode I've made the requested changes. |
Thanks for the review. I've fixed that. |
There was a problem hiding this comment.
I still sometimes don't see any modal when i navigate to any other page without assigning team members.
How to reproduce?
- Create a collective team event type
- Go to event setup tab and change location and click save
and then navigate to any other page by clicking on 'Bookings'
| if ( | ||
| eventType.hosts.length === 0 && | ||
| !leaveWithoutAssigningHosts.current && | ||
| (url === "/event-types" || paths[1] !== "event-types") |
There was a problem hiding this comment.
If we want to show warning dialog only when navigating to a non /event-types route, do we need the url === "/event-types" check on line 214?
| } = props; | ||
| const router = useRouter(); | ||
| return ( | ||
| <Dialog open={isOpenAssignmentWarnDialog} onOpenChange={setIsOpenAssignmentWarnDialog}> |
There was a problem hiding this comment.
You know what would be cool, if Go Back and Assign is clicked, that it re-directs to the /event-types/:id?tabName=team to land user on the page where he / she can assign the user. Otherwise the user needs to figure out which tab to press for assignement.
There was a problem hiding this comment.
sure Lauris, that's a cool idea.
There was a problem hiding this comment.
Amazing! Thank you Anik!
What does this PR do?
Fixes #14848