chore: remove personal branding if in an org and use org branding #14872
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
enterprise
Graphite Automations"Add community label" took an action on this PR • (05/03/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/03/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventeen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
| const session = useSession(); | ||
| const router = useRouter(); | ||
| if (!!session.data?.user?.org?.id) { | ||
| router.replace("/settings/organizations/profile"); | ||
| } |
There was a problem hiding this comment.
I think we should just hide the tab instead of doing this
There was a problem hiding this comment.
Hey Udit, I already hide this tab in the settings layout. We added it because if a user tries to access the page using the link, then we redirect them to the profile page.
| <LicenseRequired> | ||
| <Meta | ||
| title={t("appearance")} | ||
| description={t("appearance_org_description")} | ||
| borderInShellHeader={false} | ||
| /> |
There was a problem hiding this comment.
Why did you remove LicenseRequired and Meta ?
There was a problem hiding this comment.
We used the component in the profile section, where LicenseRequired and Meta were already used as parents.
| @@ -27,7 +24,6 @@ type BrandColorsFormValues = { | |||
|
|
|||
| const OrgAppearanceView = ({ | |||
| currentOrg, | |||
| isAdminOrOwner, | |||
There was a problem hiding this comment.
Only admin or owner should be able to change organization's appearance settings.
There was a problem hiding this comment.
We handle it in the profile section. Do we need to check each one individually?
What does this PR do?
Fixes #14090
