Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3655] Add API build cache in CI pipeline #14921

Closed
keithwillcode opened this issue May 7, 2024 · 1 comment · Fixed by #14929
Closed

[CAL-3655] Add API build cache in CI pipeline #14921

keithwillcode opened this issue May 7, 2024 · 1 comment · Fixed by #14929
Labels
api area: API, enterprise API, access token, OAuth ci area: CI, DX, pipeline, github actions Low priority Created by Linear-GitHub Sync
Milestone
v4.2

Comments

@keithwillcode
Copy link
Contributor

keithwillcode commented May 7, 2024 •
edited

We now build API v1 and v2 on every PR but they are not being cached, making future re-runs of the CI pipeline that have previously failed due to test flakes slower.

Update https://github.com/calcom/cal.com/blob/main/.github/workflows/api-v1-production-build.yml and https://github.com/calcom/cal.com/blob/main/.github/workflows/api-v2-production-build.yml to do what https://github.com/calcom/cal.com/blob/main/.github/actions/cache-build/action.yml is doing in terms of caching.

From SyncLinear.com | CAL-3655
@keithwillcode keithwillcode added ci area: CI, DX, pipeline, github actions Low priority Created by Linear-GitHub Sync labels May 7, 2024
@dosubot dosubot bot added the api area: API, enterprise API, access token, OAuth label May 7, 2024
@keithwillcode keithwillcode changed the title [CAL-3655] Build API v2 build cache in CI pipeline [CAL-3655] Add API build cache in CI pipeline May 7, 2024
@utkershrajvenshi utkershrajvenshi mentioned this issue May 7, 2024
Merged
1 task
@utkershrajvenshi
Copy link
Contributor

Hi @keithwillcode , opened up a PR for a possible fix. Please review and suggest any changes that are needed 🙏

@dosubot dosubot bot modified the milestone: v4.2 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth ci area: CI, DX, pipeline, github actions Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v4.2
Development

Successfully merging a pull request may close this issue.

chore: API Build cache in CI pipeline utkershrajvenshi/cal.com
2 participants
@keithwillcode @utkershrajvenshi