Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve bw/entrypoint.sh behaviour #868

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ppenguin
Copy link

Remove infinite restart-loop with incorrect condition; make container exit with rc 1 if main nginx exits uncleanly.

I'm not 100% sure whether this leads to the desired behaviour yet (should be tested).

Before: if the nginx process crashes, wait $pid stops blocking, but the crashed proces doesn't cleanup the pid file so the while loop does nothing and causes 100% load.

After: if the main nginx proces exits without cleaning up the pid file, it is considered an unclean/unexpected exit and causes the stale pid file to be cleaned up by the entrypoint and the container exiting with status 1.

However: if the container orchestrator is configured to restart containers on failure, this would cause a new bw instance to be started, so far so good. BUT: will this newly started container request the needed configs from the scheduler upon startup? Or is configuring "push only" (scheduler -> bw)? In the latter case we still have a problem.

@ppenguin ppenguin marked this pull request as draft January 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant