Add "User Service Account Impersonation" as an auth mode for GCP #7224
Conversation
| @@ -69,7 +69,7 @@ final private[spi] case class UnixPath(path: String) extends CharSequence { | |||
|
|
|||
| def isAbsolute: Boolean = UnixPath.isAbsolute(path) | |||
|
|
|||
| def isEmpty: Boolean = path.isEmpty | |||
| override def isEmpty: Boolean = path.isEmpty | |||
There was a problem hiding this comment.
Compiler was breaking without this, not related to PR
There was a problem hiding this comment.
Out of curiosity, what is your Java version?
I believe Cromwell is usually compiled with Java 11, and CharSequence::isEmpty is "Since: 15"
This override will need to be fixed, but maybe not right now?
Btw, I use SDKMAN! to keep all my Java SDKs under control. The JDK referenced by Cromwell's config isn't available for my M2 mac. I've just changed it on my machine to a newer 11 Temurin release.
There was a problem hiding this comment.
Thanks! That was the issue. Have you had a moment to review the PR otherwise?
There was a problem hiding this comment.
Have you had a moment to review the PR otherwise?
I've glanced at it, but I'm not an official committer at the moment. I've got multiple of own PRs in the queue to get reviewed 😅
In the meantime I've just coalesced my commits into a fork and just compile and run that melange to keep moving.
Issue: #7223
If the team would prefer a smaller PR
We could change this to only ever use applicationDefaultCredentials, in which case we could remove parts of the code that are altering ServiceAccountMode