-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Toyota Supra #565
base: master
Are you sure you want to change the base?
Conversation
Nice, thanks! Didn't know that there are even more cars and brands using NBT systems. Is it only the Supra? And only in the US? Or also globally/other cars? Regarding the |
For Toyota, yeah only the Supra. For other brands it's only Rolls Royce as far as I can tell (see the last paragraph in the intro here: https://en.wikipedia.org/wiki/BMW_iDrive). The Supra is available in at least Europe but no clue about China.
The problem with this is that One approach might still be to include |
Interesting! I could imagine something like this: @classmethod
@property
def api_brands(cls) -> list[str]:
"""Return members for API calls."""
return (cls._member_map_[name] for name in cls._member_names_ if name != "DRITTKUNDE") |
IMO, I think that implementation would become a footgun, as it would break the normal/expected Enum iteration (i.e. you would have to know to do |
@rikroe Thoughts? |
I see your point. But to be honest, I also have no other idea. |
Sorry for the delay @rikroe. Updated |
With #591 merged, could you please have another look? The URLs and return values do differ for the vehicle list, and I'm especially curious if there is any change regarding the returned brands. Also, I have updated the tests so it is hopefully easier to understand where to adjust them. |
@rikroe @vanshg Hey everyone, I was looking for an API to interact with my Supra and stumbled upon this over some Home Assistant forums. For my use case I just want a local project to mess around and don't need all the bulk of HA. I installed this package and tried to use the CLI tool to login, there are no obvious errors but it returns vehicles as 0 so assume it can't find any cars on my profile. Any ideas? Update: after running bimmerconnected vehiclefinder |
Proposed change
This is a first attempt to add support for Toyota Supra, for which the Supra Connect service uses the same underlying APIs.
Type of change
Additional information
The API expects the value
toyota
in the request, however, it returnsDRITTKUNDE
as the response (German for "third party vendor"). To address this, the fallback parsing was updated to default toCarBrand.Toyota
ifDRITTKUNDE
is returned. However, for all I know there may be other brands that also useDRITTKUNDE
...(Rolls Royce infotainments are also iDrive based)I have not yet had a chance to test this. Here is the fingerprint:
toyota_supra_fingerprint.zip
Checklist