Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEPs redirect cleanup #399

Merged
merged 2 commits into from
May 30, 2024
Merged

BEPs redirect cleanup #399

merged 2 commits into from
May 30, 2024

Conversation

iamdamion
Copy link
Contributor

  • Cleaned up BEPs links to not redirect.
  • Made all external links in new tab.
  • Adjusted beps table jinja file to take link from yaml file

- Cleaned up BEPs links to not redirect.
- Made all external links in new tab.
- Adjusted beps table jinja file to take link from yaml file
@iamdamion iamdamion linked an issue May 20, 2024 that may be closed by this pull request
data/beps.yml Outdated
@@ -98,6 +104,7 @@

- number: '020'
title: Eye Tracking including Gaze Position and Pupil Size
link: https://docs.google.com/document/d/1eggzTCzSHG3AEKhtnEDbcdk-2avXN6I94X8aUPEBVsw/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a PR for this now

data/beps.yml Outdated
@@ -132,12 +140,13 @@

- number: '022'
title: Magnetic Resonance Spectroscopy (MRS)
link: https://docs.google.com/document/d/1pWCb02YNv5W-UZZja24fZrdXLm4X7knXMiZI7E2z7mY/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a PR for this now

data/beps.yml Outdated
@@ -247,11 +262,12 @@

- number: '034'
title: Computational modeling
link: https://docs.google.com/document/d/1NT1ERdL41oz3NibIFRyVQ2iR8xH-dKY-lRCB4eyVeRo/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a PR for this on but am not 100% sure

# leads:
# - name:
# content:
# - raw

- number: '001'
title: Quantitative MRI (qMRI)
link: https://github.com/bids-bep001/bids-specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to point to the relevant appendix section of the spec website

@@ -20,19 +22,21 @@

- number: '002'
title: BIDS Models Specification
link: https://docs.google.com/document/d/1bq5eNDHTb6Nkx3WUiOBgKvLNnaa5OMcGtD0AZ9yms2M/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to point to URL of the current bids stats model website

this website will ultimately move when we merge all our website but let's start with valid URL for now

configuration and intervention required from the user.
google_doc_created: 2016-09
pull_request_created: 2018-10
pull_request_merged: 2023-08

- number: '003'
title: Common Derivatives
link: https://github.com/bids-standard/bids-specification/pull/265
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to point to the relevant derivtives section of the specification

@@ -45,6 +49,7 @@

- number: '005'
title: Arterial Spin Labeling (ASL)
link: https://docs.google.com/document/d/15tnn5F10KpgHypaQJNNGiNKsni9035GtDqJzWqkkP6c/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the ASL section in the spec

@@ -58,6 +63,7 @@

- number: '006'
title: Electroencephalography (EEG)
link: https://docs.google.com/document/d/1ArMZ9Y_quTKXC-jNXZksnedK2VHHoKP3HCeO5HPcgLE/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the EEG section in the spec

@@ -70,6 +76,7 @@

- number: '007'
title: Hierarchical Event Descriptor (HED) Tags
link: https://docs.google.com/document/d/1gs7USIVO1OApZs3IVo6TeXw9_tfzxhjM2-m--ex4g6o/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the HED section in the spec

@@ -80,6 +87,7 @@

- number: '008'
title: Magnetoencephalography (MEG)
link: https://docs.google.com/document/d/1FWex_kSPWVh_f4rKgd5rxJmxlboAPtQlmBc1gyZlRZM/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the MEG section in the spec

@@ -90,6 +98,7 @@

- number: '009'
title: Positron Emission Tomography (PET)
link: https://github.com/bids-standard/bids-specification/pull/633
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the PET section in the spec

@@ -100,6 +109,7 @@

- number: '010'
title: intracranial Electroencephalography (iEEG)
link: https://docs.google.com/document/d/1qMUkoaXzRMlJuOcfTYNr3fTsrl4SewWjffjMD5Ew6GY/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the iEEG section in the spec

@@ -111,6 +121,7 @@

- number: '018'
title: Genetic information
link: https://docs.google.com/document/d/1uRkgyzESLKuGjXi98Z97Wh6vt-iLN5nOAb9TG16CjUs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the genetics section in the spec

@@ -123,6 +134,7 @@

- number: '027'
title: BIDS Applications 2.0
link: https://docs.google.com/document/d/104HLZedFtx0TaXEUwd7eyWvJUlc0CcSUtCzwjNgmGxE/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the bids-execution website

this one too will be merged with the rest but once again let's use valid URLs for now

@@ -134,6 +146,7 @@

- number: '029'
title: Virtual and physical motion data
link: https://docs.google.com/document/d/1iaaLKgWjK5pcISD1MVxHKexB3PZWfE2aAC5HF_pCZWo/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to motion part of the spec

@@ -146,6 +159,7 @@

- number: '030'
title: Near Infrared Spectroscopy (NIRS)
link: https://docs.google.com/document/d/1FzPt7TVpIAtlhrF9_9b2VBCZOrRXJASEMyHndhDQKl8/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to NIRS seection of the spec

@@ -157,6 +171,7 @@

- number: '031'
title: Microscopy
link: https://docs.google.com/document/d/1Nlu6QVQrbOQtdtcRarsONbX5SrOubXWBvkV37LRRqrc/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to microscopy section of the spec

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly needs changing the links of the merged BEPs to point to either real websites or the relevant section of the spec

corrected links to point to PR (if available) or spec website (if completed)
@iamdamion
Copy link
Contributor Author

updated links according to notes above

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@Remi-Gau Remi-Gau merged commit 2ce099d into main May 30, 2024
2 of 5 checks passed
@Remi-Gau Remi-Gau deleted the dvd-edits branch May 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix links for BEPS
2 participants