Automerge PRs action #1823
Automerge PRs action #1823
Conversation
Created from https://github.com/pascalgn/automerge-action/ example with 5 days delay coded up with chatgpt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 16 16
Lines 1375 1375
=======================================
Hits 1209 1209
Misses 166 166 ☔ View full report in Codecov by Sentry. |
| name: automerge | ||
| on: | ||
| schedule: | ||
| - cron: '4 5 * * *' # Runs at 04:05 (random) UTC every day |
There was a problem hiding this comment.
Actually, the expression is for 5:04.
There was a problem hiding this comment.
;-) thanks
| - cron: '4 5 * * *' # Runs at 04:05 (random) UTC every day | |
| - cron: '4 5 * * *' # Runs at 05:04 (random) UTC every day |
| automerge: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
| - uses: actions/checkout@v3 | |
| - uses: actions/checkout@v4 |
| run: | | ||
| LAST_COMMIT_DATE=$(git log -1 --format=%cI) | ||
| echo "Last commit date: $LAST_COMMIT_DATE" | ||
| echo "::set-output name=last_commit_date::$LAST_COMMIT_DATE" |
There was a problem hiding this comment.
| echo "::set-output name=last_commit_date::$LAST_COMMIT_DATE" | |
| echo "last_commit_date=$LAST_COMMIT_DATE" >> "$GITHUB_OUTPUT" |
The ::set-output method is deprecated; you need to write to $GITHUB_OUTPUT now.
|
|
||
| - name: Calculate days since last commit | ||
| id: days_since_last_commit | ||
| run: | |
There was a problem hiding this comment.
You need to add shell: python for this.
| delta = now - last_commit_datetime | ||
| days_since = delta.days | ||
| echo "Days since last commit: $days_since" | ||
| echo "::set-output name=days_since::$days_since" |
There was a problem hiding this comment.
| echo "::set-output name=days_since::$days_since" | |
| echo "days_since=$days_since" >> "$GITHUB_OUTPUT" |
| - name: Get date of the last commit | ||
| id: last_commit_date | ||
| run: | | ||
| LAST_COMMIT_DATE=$(git log -1 --format=%cI) |
There was a problem hiding this comment.
This can be faked by the Git user. It'd be better to fetch the head.pushed_at timestamp for the PR from the GitHub API.
| - id: automerge | ||
| name: automerge | ||
| uses: "pascalgn/automerge-action@v0.16.3" | ||
| if: steps.days_since_last_commit.outputs.days_since > 5 && ((github.event_name == 'pull_request' && github.event.action == 'labeled') || github.event_name == 'schedule') |
There was a problem hiding this comment.
Shouldn't you add some sort of check that tests have passed, or does the action take care of that?
| @@ -0,0 +1,60 @@ | |||
| name: automerge | |||
| on: | |||
| schedule: | |||
There was a problem hiding this comment.
Problem: Scheduled runs only happen against the default branch, not against PRs.
There was a problem hiding this comment.
oh, that's a boomer... So the only way would be for a dedicated action to go through open PRs and see if any need to be triggered to be reran or do you see some other way?
There was a problem hiding this comment.
Do you mean "merged" instead of "reran"?
Aside from that, yes, that's pretty much the only way.
|
Even if this succeeds in merging PRs after 5 days, it won't prevent merging before the 5 days are up, which seems like the more important qualification to me. |
xref:
Inspired by
TODOs