Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] check format 'IntendedFor' fields in json files #408

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Sep 2, 2023

@effigies
Copy link
Contributor

effigies commented Sep 2, 2023

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Sep 2, 2023

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

you mean like pybids resolving them for example?

In any case fine with me.

I will wrap up this PR and we can leave it hanging until we feel like using it (or not): this was not a lot of work anyway.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "python tools/update_intended_for.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Sep 2, 2023

ok added a script to maybe help us convert those URI in batches but the diff gets huge because it may alter the formatting of entire json files at times... so may need improvement...

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Sep 2, 2023

apparently this shows that the new format of URI is not supported for mircroscopy by the current version of the validator: should I open an issue on the validator at least for book keeping?

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Sep 5, 2023

@sappelhoff
Copy link
Member

apparently this shows that the new format of URI is not supported for mircroscopy by the current version of the validator: should I open an issue on the validator at least for book keeping?

yes please, we should support BIDS URIs in all our validators, even the legacy one

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated format for "URI" in IntendedFor` fields
3 participants