Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add example dataset for MRI chunk entity #405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

valosekj
Copy link

@valosekj valosekj commented Aug 29, 2023

This PR adds an example dataset for the MRI chunk entity.

The "chunk" entity is added to the MRI datatype in bids-standard/bids-specification#1586.

Note that I intentionally did not truncate the data to preserve its nifti header with qforms for different chunks (FOVs). Instead, I created empty masks of the original images --> images are empty, but the nifti header has been preserved.

@effigies
Copy link
Contributor

Please truncate the NIfTI files to headers.

zcat img.nii.gz | head -c 352 | gzip - | sponge img.nii.gz

@valosekj
Copy link
Author

Please truncate the NIfTI files to headers.

zcat img.nii.gz | head -c 352 | gzip - | sponge img.nii.gz

Thanks! Done in 6a84c8f

@Remi-Gau
Copy link
Contributor

Could you update the dataset listing?

https://github.com/bids-standard/bids-examples/blob/master/CONTRIBUTING.md#how-to-generate-the-tables-in-the-readme

It is in the root of the repo:
https://github.com/bids-standard/bids-examples/blob/master/dataset_listing.tsv

Ideally it should link to where the "real" data is: may be quite useful in this case

@valosekj
Copy link
Author

Could you update the dataset listing?

https://github.com/bids-standard/bids-examples/blob/master/CONTRIBUTING.md#how-to-generate-the-tables-in-the-readme

It is in the root of the repo: https://github.com/bids-standard/bids-examples/blob/master/dataset_listing.tsv

Done in ec44bc3.

Ideally it should link to where the "real" data is: may be quite useful in this case

Unfortunately, the dataset is not publicly available. And I am not aware of any public MRI dataset with "chunks".

@Remi-Gau
Copy link
Contributor

Unfortunately, the dataset is not publicly available. And I am not aware of any public MRI dataset with "chunks".

OK let's keep like that for now but it would be good in the future to be able to point to a real one.

@valosekj
Copy link
Author

Since the corresponding PR has been merged, maybe this PR could be merged as well?

@effigies effigies force-pushed the jv/add_mri_chunk_example_dataset branch from ec44bc3 to 43d3a2c Compare November 21, 2023 01:06
@Remi-Gau
Copy link
Contributor

I think this will have to wait for the BIDS validator to be changed to accept this new entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants