Fix source maps for private member expressions #16514
Merged
+636
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Polish 💅
nicolo-ribaudo
commented
May 19, 2024
Comment on lines
+9
to
+11
| babelHelpers.classPrivateFieldGet2(_field, this); | ||
| babelHelpers.classPrivateGetter(_A_brand, this, _get_getter); | ||
| babelHelpers.assertClassBrand(_A_brand, this, _method); |
There was a problem hiding this comment.
Previously _field, _get_getter and _method were unmapped. Now they are mapped to #field, #getter and #method of the member expression.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56985 |
nicolo-ribaudo
added
PR: Polish 💅
nicolo-ribaudo
commented
May 19, 2024
Comment on lines
151
to
172
| (13:10-16) Expr(this.#fie <-- (12:10-11) Expr(babe | ||
| ^^^^^^ ^ | ||
| (13:10-11) Expr(this <-- (12:10-11) Expr(babe | ||
| ^ ^ | ||
|
|
||
| (13:10-16) Expr(this.#fie <-- (12:11-23) xpr(babelHelpers.cla | ||
| ^^^^^^ ^^^^^^^^^^^^ | ||
| (13:11-16) xpr(this.#fie <-- (12:11-23) xpr(babelHelpers.cla | ||
| ^^^^^ ^^^^^^^^^^^^ | ||
|
|
||
| (13:10-16) Expr(this.#fie <-- (12:23-24) pers.clas | ||
| ^^^^^^ ^ | ||
| (13:11-16) xpr(this.#fie <-- (12:23-24) pers.clas | ||
| ^^^^^ ^ | ||
|
|
||
| (13:10-16) Expr(this.#fie <-- (12:24-45) ers.classPrivateFieldGet2(_fi | ||
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ | ||
| (13:11-16) xpr(this.#fie <-- (12:24-45) ers.classPrivateFieldGet2(_fi | ||
| ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| (13:10-16) Expr(this.#fie <-- (12:45-46) Get2(_fie | ||
| ^^^^^^ ^ | ||
| (13:11-16) xpr(this.#fie <-- (12:45-46) Get2(_fie |
There was a problem hiding this comment.
This is another fix. Previously, babelHelpers.classPrivateFieldGet2... had no loc info so it was merged with the previous token (in this example, the ( of inExpr().
Now it's a bit weird that the closing paren of the babelHelpers.classPrivateFieldGet2 call is mapped to the last character of the private name, but in practice it's ok since no error or breakpoint will ever point to it.
nicolo-ribaudo
removed
the
PR: Polish 💅
nicolo-ribaudo
changed the title
nicolo-ribaudo
changed the title
JLHwung
approved these changes
May 19, 2024
liuxingbaoyu
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2