-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate helper metadata at build time #16501
Generate helper metadata at build time #16501
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57012 |
17a94db
to
7883619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I like this!
0ca190e
to
0c29d67
Compare
c95ee9a
to
fc45887
Compare
6f9b0fc
to
168c0d2
Compare
this.v = value; | ||
this.k = kind; | ||
} | ||
|
||
export { _OverloadYield as default }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for this is needed in #16510
168c0d2
to
b3c396e
Compare
The
|
Fixes #1, Fixes #2
The goal of this PR is to:
File
class that needs to be injected from@babel/core
to@babel/helpers
through.ensure(name, FileClass)
This PR reduces the time needed to process a single helper by half (
allHelpersNames.map(name => this.addHelper(name));
takes 100ms rather than 190ms on my machine)