chore(bench): upgrade rustls #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
reviewed
May 14, 2024
- specify only major version for dependency - factor out crypto provider - add documentation about item type
Rustls no defaults to AWS-LC, so some of our other scripts are no longer necessary. Also update docs to keep them accurate.
toidiu
approved these changes
May 15, 2024
maddeleine
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We should be using the latest version of rustls available when benchmarking.
Call Outs
With this change, we are not using the rustls default cryptographic provider of aws-lc-rs. Therefore we can remove some of the old scripts that were previously used to test rustls with aws-lc, and we also update the readme since Ring is no longer the default.
Testing:
Unit tests/CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.