[pycodestyle] Remove deprecated functionality from type-comparison (E721)

[augustelalande]

Summary

Stabilizes E721 behavior implemented in #7905.

The functionality change in E721 was implemented in #7905, released in v0.1.2. And seems functionally stable since #9676, without an explicit release but would correspond to v0.2.0. So the deprecated functionally should be removable in the next minor release.

[zanieb]

To clarify, this looks like it stabilizes the preview behavior introduced in #9676 correct?

[augustelalande]

Yes, sorry I wasn't clear. I updated the PR summary accordingly.

[github-actions]

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+313 -251 violations, +0 -0 fixes in 19 projects; 25 projects unchanged)

DisnakeDev/disnake (+4 -0 violations, +0 -0 fixes)

+ disnake/ext/commands/params.py:807:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/ext/commands/test_params.py:143:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/ext/commands/test_params.py:146:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/ext/commands/test_params.py:214:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

RasaHQ/rasa (+12 -0 violations, +0 -0 fixes)

+ .github/tests/test_validate_gpus.py:26:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ rasa/shared/utils/io.py:66:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ rasa/shared/utils/io.py:68:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ rasa/shared/utils/io.py:93:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/cli/test_utils.py:458:13: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/cli/test_utils.py:513:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/conftest.py:891:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_actions.py:2811:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/shared/core/test_domain.py:1856:13: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/shared/core/training_data/story_reader/test_yaml_story_reader.py:272:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
... 2 additional changes omitted for project

alteryx/featuretools (+3 -0 violations, +0 -0 fixes)

+ featuretools/tests/entityset_tests/test_es.py:860:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ featuretools/tests/entityset_tests/test_serialization.py:134:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ featuretools/tests/entityset_tests/test_serialization.py:135:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

PlasmaPy/PlasmaPy (+1 -0 violations, +0 -0 fixes)

+ tests/particles/test_exceptions.py:1040:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

apache/airflow (+9 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

+ airflow/models/abstractoperator.py:425:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ airflow/models/abstractoperator.py:427:14: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ airflow/models/abstractoperator.py:429:14: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_configuration.py:1487:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_configuration.py:1497:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_configuration.py:1521:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_configuration.py:1526:20: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_stats.py:387:20: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/core/test_stats.py:394:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

bokeh/bokeh (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

+ tests/unit/bokeh/core/property/test_primitive.py:249:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ tests/unit/bokeh/models/test_sources.py:288:20: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

demisto/content (+124 -231 violations, +0 -0 fixes)

+ Packs/AHA/Integrations/AHA/AHA_test.py:89:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:355:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:355:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:356:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:356:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:357:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:357:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:358:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:358:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:359:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector_test.py:359:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-IAM/Integrations/AWS-IAM/AWS-IAM_test.py:433:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-IAM/Integrations/AWS-IAM/AWS-IAM_test.py:433:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub_test.py:323:12: E721 Do not compare types, use `isinstance()`
+ Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub_test.py:323:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AWS_Sagemaker/Integrations/AWSSagemaker/AWSSagemaker.py:52:8: E721 Do not compare types, use `isinstance()`
+ Packs/AWS_Sagemaker/Integrations/AWSSagemaker/AWSSagemaker.py:52:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/AbuseDB/Integrations/AbuseDB/AbuseDB.py:323:24: E721 Do not compare types, use `isinstance()`
- Packs/AcalvioShadowplex/Integrations/acalvioapp/acalvioapp.py:148:17: E721 Do not compare types, use `isinstance()`
- Packs/AcalvioShadowplex/Integrations/acalvioapp/acalvioapp.py:171:17: E721 Do not compare types, use `isinstance()`
- Packs/AcalvioShadowplex/Integrations/acalvioapp/acalvioapp.py:207:17: E721 Do not compare types, use `isinstance()`
- Packs/AcalvioShadowplex/Integrations/acalvioapp/acalvioapp.py:244:17: E721 Do not compare types, use `isinstance()`
- Packs/AccentureCTI/Integrations/ACTIIndicatorQuery/ACTIIndicatorQuery.py:230:8: E721 Do not compare types, use `isinstance()`
- Packs/AccentureCTI/Integrations/ACTIIndicatorQuery/ACTIIndicatorQuery.py:234:8: E721 Do not compare types, use `isinstance()`
- Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:36:13: E721 Do not compare types, use `isinstance()`
+ Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:36:13: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:36:40: E721 Do not compare types, use `isinstance()`
+ Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:36:40: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:37:17: E721 Do not compare types, use `isinstance()`
+ Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:37:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
- Packs/Active_Directory_Query/Scripts/SendEmailToManager/SendEmailToManager.py:43:42: E721 Do not compare types, use `isinstance()`
... 324 additional changes omitted for project

freedomofpress/securedrop (+0 -3 violations, +0 -0 fixes)

- admin/securedrop_admin/__init__.py:588:12: E721 Do not compare types, use `isinstance()`
- admin/securedrop_admin/__init__.py:590:12: E721 Do not compare types, use `isinstance()`
- admin/securedrop_admin/__init__.py:594:12: E721 Do not compare types, use `isinstance()`

ibis-project/ibis (+8 -0 violations, +0 -0 fixes)

+ ibis/backends/dask/convert.py:28:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/backends/pandas/convert.py:28:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/backends/tests/test_client.py:1094:13: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/tests/expr/test_sql_builtins.py:116:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/tests/expr/test_sql_builtins.py:117:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/tests/expr/test_sql_builtins.py:137:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/tests/expr/test_sql_builtins.py:174:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
+ ibis/tests/expr/test_sql_builtins.py:90:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
E721	564	313	251	0	0

Linter (preview)

✅ ecosystem check detected no linter changes.

[zanieb]

Thanks this makes sense to me but we need to wait until 0.5.0 to merge.