-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add unit test #30587
Feature/add unit test #30587
Conversation
DataSourceUnitPersistService DataSourceNodePersistService DatabaseRulePersistService TableMetaDataPersistService ViewMetaDataPersistService PropertiesPersistService GlobalRulePersistService DatabaseMetaDataPersistService MetaDataVersionPersistService StandaloneContextManagerBuilder
Hi @taojintianxia , please review and let me know if any changes are required in this PR. Thanks! |
...ore/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java
Show resolved
Hide resolved
...ore/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java
Outdated
Show resolved
Hide resolved
...re/metadata/persist/service/config/database/datasource/DataSourceNodePersistServiceTest.java
Outdated
Show resolved
Hide resolved
...re/metadata/persist/service/config/database/datasource/DataSourceNodePersistServiceTest.java
Outdated
Show resolved
Hide resolved
@zhaojinchao95 thx for the remind, i will fix them properly later |
@zhaojinchao95 Hi, i have redone the codes , pls help me review the again, thx 😊 |
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.