Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][site] Doc changes to support peekMessages with Offset in admin-api-topics #840

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shravannarayan-es
Copy link

This PR adds doc for PIP-332 PR

@visortelle visortelle marked this pull request as draft March 12, 2024 07:35
@visortelle
Copy link
Member

@shravannarayan-es I converted the PR to draft because the PIP's PR hasn't been merged yet.

@@ -522,6 +522,28 @@ admin.topics().peekMessages(topic, subName, numMessages);

</TabItem>

</Tabs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you targeted 2.11.x file, but your PIP implementation is targeted at master which is 3.2, no?

````
### Peek messages with Offset

You can also start to peek number of messages for a specific subscription of a given topic from a particular offset position in the following ways.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start?
Maybe
You can peek a number of messages, for a specific subscription of a topic, from a given offset position, in the following ways:


You can also start to peek number of messages for a specific subscription of a given topic from a particular offset position in the following ways.

````mdx-code-block
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add not just java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants