Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error log level to warning. #194

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

GooDer
Copy link

@GooDer GooDer commented May 16, 2024

It is some auto correction and PDF will be processed even with these problems so I want to avoid error alerts to be triggered.

User mail list doesn't work for me somehow so I am proposing it this way.

… will be processed even with these problems so I want to avoid error alerts to be triggered.
@THausherr
Copy link
Contributor

THausherr commented May 16, 2024

These are nasty problems. The PDF is definitively messed up and it should be checked with the sender whether it is correct. Just because you get the same content than with Adobe doesn't mean everything is OK.

@GooDer
Copy link
Author

GooDer commented May 20, 2024

Hi @THausherr sorry for late reply.

I agree that PDF is not in good shape, but unfortunately it is some input from users / companies which we need to process even if there are some problems.

Logging that error is problem for our alerting system, which is triggered for every error logged.

I can see three possibilities, how to handle this:

  1. as proposed in PR, change log level to warning. PDF is still processed even that this error occure
  2. gather errors in some list and allow user of the library to decide what to do in case of error
  3. switch of error logging for that class, which could be dangerous
  4. allow to provide some configuration to parser/library in which level this should be logged (with error as default)

Please suggest what would be the best choice in this case.

Thanks you

@THausherr
Copy link
Contributor

I like none; however with log4j you can limit output in specific classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants