Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1706] improvement: Upgrade the default NodeJS and npm versions of dashboard. #1707

Merged
merged 1 commit into from
May 23, 2024

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented May 12, 2024

What changes were proposed in this pull request?

Upgrade the versions of NodeJS and npm.

Why are the changes needed?

The dashboard on MacOS does not support the M-chip of Node14, resulting in a local compilation failure, and you need to upgrade to Node16 or npm8 or later.

Fix: #1706

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No testing required.

Copy link

Test Results

 2 391 files  ±0   2 391 suites  ±0   4h 57m 40s ⏱️ +50s
   928 tests ±0     927 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 754 runs  ±0  10 740 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit b9e682f. ± Comparison against base commit 8e26a34.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi changed the title [Improvement] Upgrade the default NodeJS and npm versions of dashboard. [#1706] improvement: Upgrade the default NodeJS and npm versions of dashboard. May 17, 2024
@rickyma
Copy link
Contributor

rickyma commented May 22, 2024

We can merge this.

@jerqi jerqi merged commit ac92ae7 into apache:master May 23, 2024
41 checks passed
@jerqi
Copy link
Contributor

jerqi commented May 23, 2024

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Upgrade the default NodeJS and npm versions of dashboard.
3 participants