[VL] Enable local sort-based shuffle #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
local-sort-shuffle
branch
from
eb0e683
to
334c182
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
local-sort-shuffle
branch
from
0331da5
to
58284b0
Compare
|
Run Gluten Clickhouse CI |
|
The UT failure of commit 56580aa is due to metrics changed which causes AQE suites failure https://github.com/apache/incubator-gluten/actions/runs/9185004959 |
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature. In TPCH benchmark, we observed significant performance drop and higher memory pressure
using default shuffle partitions (2x~4x vcore#) comparing with hash-based shuffle. The sort-based shuffle will be enabled if shuffle partitions is greater than
spark.gluten.sql.columnar.shuffle.sort.threshold(default value 100'000). It's recommended not to enable local sort-base shuffle until we fix the performance.