Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reactions to question & answer #943

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

feat: add reactions to question & answer #943

wants to merge 13 commits into from
+868 −201

Conversation

hgaol
Copy link
Contributor

@hgaol hgaol commented May 7, 2024 •
edited

close #883 .

done
backend:

  • used meta table to save reactions.
  • created 2 APIs. one is to retrieve meta for an object, the other is to add or update.

frontend:

  • added an Reaction component.
  • to make it easy to determine if it's need to show the Add a comment button, place it in the Comment component.

todo

  • add i18n for reactions.

@hgaol
Copy link
Contributor Author

hgaol commented May 7, 2024

some screenshots.
image
image
image

@hgaol
Copy link
Contributor Author

hgaol commented May 7, 2024

add i18n.
image
image

@shuashuai shuashuai self-requested a review May 7, 2024 04:22
@LinkinStars LinkinStars self-requested a review May 7, 2024 06:15
@LinkinStars LinkinStars deleted the branch apache:dev May 7, 2024 07:02
@LinkinStars LinkinStars closed this May 7, 2024
@LinkinStars LinkinStars reopened this May 7, 2024
LinkinStars
LinkinStars requested changes May 7, 2024
View reviewed changes
internal/controller/meta_controller.go Outdated Show resolved Hide resolved
internal/controller/meta_controller.go Outdated Show resolved Hide resolved
internal/service/meta/meta_service.go Outdated Show resolved Hide resolved
internal/service/meta/meta_service.go Outdated Show resolved Hide resolved
@hgaol hgaol requested a review from LinkinStars May 8, 2024 01:26
LinkinStars
LinkinStars requested changes May 8, 2024
View reviewed changes
internal/schema/meta_schema.go Outdated Show resolved Hide resolved
internal/repo/meta/meta_repo.go Outdated Show resolved Hide resolved
internal/service/meta/meta_service.go Outdated Show resolved Hide resolved
internal/service/meta/meta_service.go Outdated Show resolved Hide resolved
@LinkinStars
Copy link
Member

@hgaol It's great, and the backend tasks were almost done. It's ready for the frontend to review. @shuashuai

@hgaol
Copy link
Contributor Author

hgaol commented May 9, 2024

Really appreciate @LinkinStars and @shuashuai for your careful and patient review! thanks!

@hgaol hgaol requested a review from LinkinStars May 9, 2024 15:55
@hgaol hgaol requested a review from shuashuai May 10, 2024 09:55
shuashuai
shuashuai approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkinStars LinkinStars LinkinStars approved these changes

@shuashuai shuashuai shuashuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hgaol @LinkinStars @shuashuai