Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build path #933

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kuai6
Copy link

@kuai6 kuai6 commented Apr 28, 2024

Hello folks.
There is the simple PR to add custom build path.

@LinkinStars LinkinStars self-requested a review April 29, 2024 02:44
@LinkinStars LinkinStars self-assigned this Apr 29, 2024
@LinkinStars LinkinStars added the enhancement Enhancement request label Apr 29, 2024
@LinkinStars
Copy link
Member

@kuai6 The function itself is fine. Can you explain the exact usage scenario?
The reason we use MkdirTemp is because it creates a random folder(answer_build4277335726) each time to prevent build exceptions when the same folder is used incorrectly during a build.

@kuai6
Copy link
Author

kuai6 commented Apr 29, 2024

@kuai6 The function itself is fine. Can you explain the exact usage scenario? The reason we use MkdirTemp is because it creates a random folder(answer_build4277335726) each time to prevent build exceptions when the same folder is used incorrectly during a build.

I want to build the app with plugins on my private env with private npm registry.

I thought this is good idea to make a way to replace some files (like .npmrc) to build the app into private env. But now i figure out it is better to build the app without answer build -with...
So this PR still not solve my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants