IGNITE-19103: Sql. Change implicit primary key column's type to UUID. #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
force-pushed
the
ignite-19103
branch
6 times, most recently
from
c4a50f9
to
21cec3a
Compare
AMashenkov
reviewed
May 20, 2024
modules/schema/src/main/java/org/apache/ignite/internal/schema/DefaultValueGenerator.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
May 20, 2024
modules/schema/src/main/java/org/apache/ignite/internal/schema/DefaultValueGenerator.java
Outdated
Show resolved
Hide resolved
AMashenkov
approved these changes
May 22, 2024
xtern
reviewed
May 22, 2024
| /** | ||
| * Check if provided default value is a constant or a functional default of supported function, or fail otherwise. | ||
| */ | ||
| static void ensureSupportedDefault(String columnName, @Nullable DefaultValue defaultValue) { | ||
| static void ensureSupportedDefault(String columnName, @Nullable DefaultValue defaultValue, ColumnType columnType) { |
There was a problem hiding this comment.
Suggested change
| static void ensureSupportedDefault(String columnName, @Nullable DefaultValue defaultValue, ColumnType columnType) { | |
| static void ensureSupportedDefault(String columnName, ColumnType columnType, @Nullable DefaultValue defaultValue) { |
to simplify future merge
|
|
||
| LENGTH(IgniteSqlFunctions.class, "length", Object.class), | ||
|
|
||
| OCTET_LENGTH(IgniteSqlFunctions.class, "octetLength", ByteString.class), | ||
| OCTET_LENGTH2(IgniteSqlFunctions.class, "octetLength", String.class), | ||
|
|
||
| /** See {@link IgniteSqlFunctions#genRandomUuid()}. */ | ||
| // TODO This function should removed when https://issues.apache.org/jira/browse/IGNITE-19103 is complete. | ||
| GEN_RANDOM_UUID(IgniteSqlFunctions.class, "genRandomUuid"), |
There was a problem hiding this comment.
please remove this method from IgniteSqlFunctions class as well.
xtern
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes type of implicit PK to UUID.
Removes
gen_random_uuidfunction.https://issues.apache.org/jira/browse/IGNITE-19103
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes