IGNITE-22118 Explicitly specify pool to execute start/stop on IgniteComponent #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return Future that will be completed when the asynchronous part of the start is processed. | ||
| */ | ||
| CompletableFuture<Void> startAsync(); | ||
| CompletableFuture<Void> startAsync(ExecutorService startupExecutor); |
There was a problem hiding this comment.
I suggest to pass something like ComponentContext instead of executor, which should provides executorservice and whatever we want later.
sanpwc
reviewed
May 23, 2024
| return updateLog.startAsync() | ||
| .thenCompose(none -> { | ||
| return updateLog.startAsync(startupExecutor) | ||
| .thenComposeAsync(none -> { | ||
| if (latestCatalogVersion() == emptyCatalog.version()) { | ||
| int initializedCatalogVersion = emptyCatalog.version() + 1; | ||
|
|
There was a problem hiding this comment.
Which thread will complete catalogReadyFuture?
There was a problem hiding this comment.
Explicitly set to the startupExecutor pool
| * | ||
| * @return Future that will be completed when the asynchronous part of the stop is processed. | ||
| */ | ||
| default CompletableFuture<Void> stopAsync() { |
There was a problem hiding this comment.
It's required for micronaut annotations on TestFactory to work.
If we are not okay with this method I can spend some time rewriting tests instead.
There was a problem hiding this comment.
Let's either rewrite the tests or mark the method as TestOnly.
sanpwc
approved these changes
May 24, 2024
ascherbakoff
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22118
Added
ExecutorServicetoIgniteComponent.startAsyncandIgniteComponent.stopAsync. Any async part of start/stop is expected to run in the corresponding thread pool.This PR is mostly the change of method signature, only a few components had their startAsync methods changed.
The ones that were changed: