IGNITE-22120: Sql. Possibility set zero length for character string type #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
changed the title
AMashenkov
reviewed
May 20, 2024
| assertThrowsSqlException( | ||
| STMT_VALIDATION_ERR, | ||
| "Length for type VARCHAR must be at least 1", | ||
| () -> sql("SELECT '1'::VARCHAR(0)") |
There was a problem hiding this comment.
Should we check an empty string?
AMashenkov
approved these changes
May 20, 2024
...ine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java
Outdated
Show resolved
Hide resolved
zstan
reviewed
May 21, 2024
| if (params.length() == null) { | ||
| throw new CatalogValidationException(format(ERR_COL_PARAM_DEFINITION, "Length", params.name(), params.type())); | ||
| } | ||
|
|
||
| if (params.length() < 0) { | ||
| if (params.length() <= 0) { |
There was a problem hiding this comment.
do we need to append additional tests for add column and alter column with "0" precision ?
...l-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java
Show resolved
Hide resolved
modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
Outdated
Show resolved
Hide resolved
Update error message.
# Conflicts: # modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test # modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java
modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
Outdated
Show resolved
Hide resolved
Update table names in test.
ygerzhedovich
approved these changes
May 22, 2024
Update column param tests.
zstan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22120
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes