IGNITE-15568 Striped Disruptor doesn't work with JRaft event handlers… #3772
Conversation
| .setProducerType(ProducerType.MULTI) | ||
| .setWaitStrategy(useYieldStrategy ? new YieldingWaitStrategy() : new BlockingWaitStrategy()) | ||
| .build(); | ||
| .setRingBufferSize(bufferSize) |
There was a problem hiding this comment.
Formatting seems incorrect
There was a problem hiding this comment.
I applied fromat that we use for all cod in our project, except the ignite-raft.
So you think this is because our format never applied to the code before, but it is right.
| @@ -121,7 +124,7 @@ public StripedDisruptor( | |||
| * @param eventFactory Event factory for the Striped disruptor. | |||
| * @param stripes Amount of stripes. | |||
| * @param supportsBatches If {@code false}, this stripe will always pass {@code true} into | |||
| * {@link EventHandler#onEvent(Object, long, boolean)}. Otherwise, the data will be provided with batches. | |||
| * {@link EventHandler#onEvent(Object, long, boolean)}. Otherwise, the data will be provided with batches. | |||
There was a problem hiding this comment.
Formatting seems incorrect
There was a problem hiding this comment.
The same as above. I have checked the formatting again.
| @@ -289,10 +301,14 @@ private class StripeEntryHandler implements EventHandler<T> { | |||
| */ | |||
| StripeEntryHandler(int stripeId) { | |||
| this.stripeId = stripeId; | |||
|
|
|||
| eventCache = supportsBatches ? null : new HashMap<>(); | |||
There was a problem hiding this comment.
Can we have different implementations of EventHandler for manual and build-in batching ?
There was a problem hiding this comment.
We don't have a different implementation.
The flag is used in the only scenario where the log storage is shared. For the shared log storage, we can handle the last messages (for the current batch) at the storage level. Althougр, this message might be intended for another handler in the same stripe.
https://issues.apache.org/jira/browse/IGNITE-15568