IGNITE-22149 Java thin: Implement partition API #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
requested changes
May 15, 2024
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientOp.java
Outdated
Show resolved
Hide resolved
.../org/apache/ignite/client/handler/requests/table/partition/ClientKeyPartitionGetRequest.java
Outdated
Show resolved
Hide resolved
.../apache/ignite/client/handler/requests/table/partition/ClientPartitionPrimaryGetRequest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/client/handler/requests/table/partition/ClientPartitionsPrimaryGetRequest.java
Outdated
Show resolved
Hide resolved
...les/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
Outdated
Show resolved
Hide resolved
ptupitsyn
requested changes
May 20, 2024
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientOp.java
Outdated
Show resolved
Hide resolved
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientOp.java
Outdated
Show resolved
Hide resolved
...ignite/client/handler/requests/table/partition/ClientPrimaryPartitionsToNodesGetRequest.java
Outdated
Show resolved
Hide resolved
...ignite/client/handler/requests/table/partition/ClientPrimaryPartitionsToNodesGetRequest.java
Outdated
Show resolved
Hide resolved
...ignite/client/handler/requests/table/partition/ClientPrimaryPartitionsToNodesGetRequest.java
Outdated
Show resolved
Hide resolved
ptupitsyn
reviewed
May 20, 2024
...ent/handler/requests/table/partition/ClientTablePartitionPrimaryReplicasNodesGetRequest.java
Outdated
Show resolved
Hide resolved
ptupitsyn
reviewed
May 20, 2024
...les/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
Show resolved
Hide resolved
ptupitsyn
reviewed
May 20, 2024
modules/client/src/main/java/org/apache/ignite/internal/client/util/Cache.java
Outdated
Show resolved
Hide resolved
ptupitsyn
changed the title
ptupitsyn
changed the title
ptupitsyn
reviewed
May 20, 2024
...les/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
Show resolved
Hide resolved
ptupitsyn
reviewed
May 20, 2024
...les/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
Show resolved
Hide resolved
ptupitsyn
reviewed
May 20, 2024
| @Override | ||
| @SuppressWarnings("resource") | ||
| public CompletableFuture<Map<Partition, ClusterNode>> primaryReplicasAsync() { | ||
| return tbl.channel().serviceAsync(ClientOp.PRIMARY_REPLICAS_GET, |
There was a problem hiding this comment.
Can we use cache in this method?
There was a problem hiding this comment.
@Pochatkin please don't resolve conversations without a reply.
added 3 commits
May 21, 2024 12:04
# Conflicts: # modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientOp.java
ptupitsyn
approved these changes
May 22, 2024
ptupitsyn
reviewed
May 22, 2024
...ent/handler/requests/table/partition/ClientTablePartitionPrimaryReplicasNodesGetRequest.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 22, 2024 12:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22149