Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-22240 Improve handling for RocksDb resources in DefaultLogStorage and SharedRocksDbInstance #3755

Merged
merged 4 commits into from
May 24, 2024

Conversation

tmgodinho
Copy link
Contributor

@tmgodinho tmgodinho commented May 14, 2024

Ticket: https://issues.apache.org/jira/browse/IGNITE-22240

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@tmgodinho tmgodinho marked this pull request as ready for review May 15, 2024 08:46
@tmgodinho
Copy link
Contributor Author

Hey @rpuch, could you check this PR as well??
Perhaps we should as @ibessonov for a review as well.

@ibessonov ibessonov changed the title ignite-22240: Improve handling for RocksDb resources in DefaultLogStorage and SharedRocksDbInstance IGNITE-22240: Improve handling for RocksDb resources in DefaultLogStorage and SharedRocksDbInstance May 15, 2024
@rpuch rpuch changed the title IGNITE-22240: Improve handling for RocksDb resources in DefaultLogStorage and SharedRocksDbInstance IGNITE-22240 Improve handling for RocksDb resources in DefaultLogStorage and SharedRocksDbInstance May 15, 2024
** Renamed ColumnFamily options to privateOptions.
** Removed TODO.
@tmgodinho tmgodinho requested a review from rpuch May 16, 2024 13:48
** Renamed ColumnFamily#options to ColumnFamily#privateOptions
@tmgodinho tmgodinho requested a review from rpuch May 20, 2024 08:18
@rpuch rpuch merged commit 2397690 into apache:main May 24, 2024
1 check passed
@rpuch rpuch deleted the ignite-22240 branch May 24, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants