-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-19670: Improve CatalogService test coverage. #3751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use tables in CatalogManagerSelfTest
zstan
approved these changes
May 15, 2024
AMashenkov
reviewed
May 15, 2024
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogTableTest.java
Show resolved
Hide resolved
AMashenkov
reviewed
May 15, 2024
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogZoneTest.java
Show resolved
Hide resolved
AMashenkov
reviewed
May 15, 2024
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogZoneTest.java
Show resolved
Hide resolved
AMashenkov
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to create a ticket to extend test coverage, or add the tests within the current PR.
Add zone test.
# Conflicts: # modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java
Update after merge.
Update after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19670
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes