IGNITE-22108 Rename options in CLI #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PakhomovAlexander
force-pushed
the
IGNITE-22108
branch
from
37047c4
to
7982dd9
Compare
…-22108 # Conflicts: # modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/ItClusterCommandTest.java # modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/init/ItClusterInitTest.java # modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/configuration/ItConfigCommandTest.java # modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/unit/ItDeploymentUnitTest.java # modules/cli/src/test/java/org/apache/ignite/internal/cli/IgniteCliInterfaceTest.java
Some options were reviewed. For example, cluster-name -> name. Also, short options that clash with each other are dropped.
valepakh
reviewed
May 15, 2024
|
|
||
| /** Meta storage node name option short name. */ | ||
| public static final String META_STORAGE_NODE_NAME_OPTION_SHORT = "-m"; | ||
| public static final String META_STORAGE_NODE_NAME_OPTION = "--ms-node"; |
There was a problem hiding this comment.
I don't think this abbreviation is something user is expecting, maybe we could keep the full option name?
There was a problem hiding this comment.
How do you think if we keep both --ms-node and --meta-storage-node?
There was a problem hiding this comment.
How do you think if we keep both
--ms-nodeand--meta-storage-node?
I think it could be confusing for users
...in/java/org/apache/ignite/internal/cli/commands/cluster/unit/ClusterUnitUndeployCommand.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/sql/SqlReplCommand.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/sql/SqlReplCommand.java
Outdated
Show resolved
Hide resolved
...pache/ignite/internal/cli/core/repl/completer/cluster/ClusterUrlDynamicCompleterFactory.java
Outdated
Show resolved
Hide resolved
modules/cli/src/test/java/org/apache/ignite/internal/cli/commands/UrlOptionsNegativeTest.java
Outdated
Show resolved
Hide resolved
…nds/cluster/unit/ClusterUnitUndeployCommand.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…nds/sql/SqlReplCommand.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…repl/completer/cluster/ClusterUrlDynamicCompleterFactory.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
valepakh
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some options were reviewed. For example, cluster-name
-> name. Also, short options that clash with each other
are dropped.
https://issues.apache.org/jira/browse/IGNITE-22108