Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Datapipeline operators and fix system tests #39716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VladaZakharova
Copy link
Contributor

This PR:

Removes datapipeline module from Google provider
Moves all the related operators inside Dataflow service, based on the API that is used inside operators
Adds new DataflowCreatePipeline, DataflowRunPipelineOperator and DataflowDeletePipelineOperator
Adds new system test file for new operators


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Collaborator

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
See my comment in Elad's thread and another one regarding naming convention

Copy link
Collaborator

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants