ARTEMIS-4702 only run command needs custom JVM settings #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}' | |||
| HAWTIO_ROLE='${role}' | |||
|
|
|||
| # Java Opts | |||
| if [ -z "$JAVA_ARGS" ]; then | |||
| if [ -z "$JAVA_ARGS" ] && [ "$1" = "run" ]; then | |||
There was a problem hiding this comment.
the export might need special memory to load large journals as well.
Also, if you don't pass an argument you may enter the shell where you can do export, data print, and also.. run from the shell. (not very common, but possible).
There was a problem hiding this comment.
There is a related problem with the log4j2 config, see: https://issues.apache.org/jira/browse/ARTEMIS-4785
in that case, we need to keep the logging just for the broker run and not for any other command. the comment on that jira has lots of good info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.