Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC auth config dump #15131

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

jessicamack
Copy link
Member

SUMMARY

dump_auth_config will now also dump OIDC config data.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • Other
AWX VERSION
awx: 24.2.1.
ADDITIONAL INFORMATION

if OIDC is not configured

    {
        "OIDC_missing_fields": [
            "KEY",
            "OIDC_ENDPOINT"
        ]
    }

if it is configured

    {
        "type": "ansible_base.authentication.authenticator_plugins.open_id_connect",
        "name": "OIDC",
        "enabled": true,
        "create_objects": true,
        "users_unique": false,
        "remove_users": true,
        "configuration": {
            "KEY": "test",
            "SECRET": "test",
            "OIDC_ENDPOINT": "https://test.com",
            "VERIFY_SSL": true
        }
    }

Copy link
Member

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feedback on this PR is the same as #15134. The current behavior of self.is_enabled() is a potential bug due to considering any explicit but false-evaluating entries the same as a missing key-value pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants