refactor(core): Add four tests and fix code to make tests pass. #55747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first test asserts that bubbling does not work right now. The second asserts that stopPropagation works, which should pass when test #1 passes too. The third test asserts properties about the events passed to the event handler. THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass.
tbondwilkinson
approved these changes
May 10, 2024
This reuses information already recorded during hydration to remove jsaction attributes to also stash event handlers. This avoids a tree walk and looku.
AndrewKushnir
added
action: review
thePunderWoman
approved these changes
May 13, 2024
| bottomEl.click(); | ||
| expect(onClickSpy).toHaveBeenCalledTimes(2); | ||
| }); | ||
| it('should not propagate events if stopPropagation is called', async () => { |
iteriani
added
action: merge
thePunderWoman
approved these changes
May 13, 2024
|
This PR was merged into the repository by commit 3ad120d. |
atscott
pushed a commit
that referenced
this pull request
May 14, 2024
The first test asserts that bubbling does not work right now. The second asserts that stopPropagation works, which should pass when test #1 passes too. The third test asserts properties about the events passed to the event handler. THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass. PR Close #55747
atscott
pushed a commit
that referenced
this pull request
May 14, 2024
This reuses information already recorded during hydration to remove jsaction attributes to also stash event handlers. This avoids a tree walk and looku. PR Close #55747
atscott
pushed a commit
that referenced
this pull request
May 14, 2024
This reuses information already recorded during hydration to remove jsaction attributes to also stash event handlers. This avoids a tree walk and looku. PR Close #55747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first test asserts that bubbling does not work right now.
The second asserts that stopPropagation works, which should pass when test #1 passes too.
The third test asserts properties about the events passed to the event handler.
THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass.
The change looks like a lot because the indentation was fixed, but look at "bubbling behavior" and "should not replay mouse events"
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information