Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch from rollup and terser to esbuild for creating contract bundle #55705

Closed
wants to merge 1 commit into from
Closed

build: switch from rollup and terser to esbuild for creating contract bundle #55705

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

This commit implements the replacement of rollup and terser with esbuild for generating the contract_bundle binary. The transition is facilitated by optimizations aimed at reducing the bundle size.

@alan-agius4 alan-agius4 added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 7, 2024
@pullapprove pullapprove bot added requires: TGP This PR requires a passing TGP before merging is allowed and removed state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 7, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 7, 2024
@ngbot ngbot bot added this to the Backlog milestone May 7, 2024
@pullapprove pullapprove bot added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate and removed area: build & ci Related the build and CI infrastructure of the project labels May 7, 2024
@ngbot ngbot bot modified the milestone: Backlog May 7, 2024
@alan-agius4
Copy link
Contributor Author

Blocked on #55587

@alan-agius4 alan-agius4 mentioned this pull request May 7, 2024
Closed
14 tasks
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 7, 2024
@ngbot ngbot bot added this to the Backlog milestone May 7, 2024
@alan-agius4 alan-agius4 added area: core Issues related to the framework runtime core: event dispatch labels May 7, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels May 8, 2024
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 8, 2024
@alan-agius4 alan-agius4 requested review from iteriani and removed request for Jesse-Good May 8, 2024 06:20
@pullapprove pullapprove bot requested a review from Jesse-Good May 8, 2024 06:20
@alan-agius4 alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 8, 2024
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented May 8, 2024 •
edited

Caretaker note: a TGP is not necessary for this change as it only changes the external build rules.

@alan-agius4 alan-agius4 removed the request for review from Jesse-Good May 8, 2024 06:21
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 10, 2024
@alan-agius4
build: switch from rollup and terser to esbuild for creating contract…
852c467 
… bundle

This commit implements the replacement of rollup and terser with esbuild for generating the contract_bundle binary. The transition is facilitated by optimizations aimed at reducing the bundle size.
@atscott
Copy link
Contributor

atscott commented May 13, 2024

This PR was merged into the repository by commit ef029b8.

@atscott atscott closed this in ef029b8 May 13, 2024
atscott pushed a commit that referenced this pull request May 13, 2024
@alan-agius4 @atscott
build: switch from rollup and terser to esbuild for creating contract…
9d1acd6 
… bundle (#55705)

This commit implements the replacement of rollup and terser with esbuild for generating the contract_bundle binary. The transition is facilitated by optimizations aimed at reducing the bundle size.

PR Close #55705
@alan-agius4 alan-agius4 deleted the jsa-esbuild branch May 14, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteriani iteriani iteriani approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alan-agius4 @atscott @iteriani @AndrewKushnir