Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add convert to DTCG spec utility WIP #1200

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: add convert to DTCG spec utility WIP #1200

merged 1 commit into from
May 23, 2024

Conversation

jorenbroekema
Copy link
Collaborator

@jorenbroekema jorenbroekema commented May 15, 2024 •
edited

  • don't change input's property keys order
  • add changeset
  • add some comments to the recursive function, so it's a bit easier to follow/read
  • add docs for utils
  • add wrapping util around it that allows passing not just a dictionary, but a files object (multiple dictionaries)
  • allow uploading a JSON file or ZIP file with files/folders containing tokens JSON files, on the docs site as a button somewhere

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aws-amplify-us-west-1 AWS Amplify (us-west-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1200.d16eby4ekpss5y.amplifyapp.com

@aws-amplify-us-west-1 AWS Amplify (us-west-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1200.d1ouz7xofr5p4l.amplifyapp.com

@jorenbroekema jorenbroekema force-pushed the convert-to-dtcg branch 3 times, most recently from fec4ae4 to ad8a1c3 Compare May 15, 2024 16:03
@jorenbroekema jorenbroekema force-pushed the convert-to-dtcg branch 2 times, most recently from 2076bbf to aa3b97d Compare May 23, 2024 09:13
@jorenbroekema jorenbroekema marked this pull request as ready for review May 23, 2024 09:13
@jorenbroekema jorenbroekema requested a review from a team as a code owner May 23, 2024 09:13
@jorenbroekema jorenbroekema merged commit 7418c97 into v4 May 23, 2024
5 checks passed
@jorenbroekema jorenbroekema deleted the convert-to-dtcg branch May 23, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@six7 six7 six7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorenbroekema @six7