Add translation validations for Editionable Worldwide Organisation parts #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that a Worldwide Organisation Page can only have a translation if the parent Editionable Worldwide Organisation also has the same translation.
brucebolt
force-pushed
the
add-ww-org-translation-validation
branch
from
71b7ff2
to
65d5af0
Compare
brucebolt
force-pushed
the
add-ww-org-translation-validation
branch
from
65d5af0
to
dd77793
Compare
yndajas
approved these changes
May 16, 2024
brucebolt
force-pushed
the
add-ww-org-translation-validation
branch
from
dd77793
to
cb2f83b
Compare
This ensures that a Worldwide Office can only have a translation if the parent Editionable Worldwide Organisation also has the same translation. The Worldwide Office itself isn't actually translatable, but the Contact is. Therefore we add the validation to the contact rather than the office itself.
brucebolt
force-pushed
the
add-ww-org-translation-validation
branch
from
cb2f83b
to
9192c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that Worldwide Organisation Pages and Worldwide Offices can only have a translation if the parent Editionable Worldwide Organisation also has the same translation.
The condition was enforced in the controllers, but adding a validation to the models ensures this conditions is enforced everywhere.
Trello card