Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate public_timestamp_datetime metadata field #272

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

csutter
Copy link
Contributor

@csutter csutter commented May 16, 2024

This allows us to use Discovery Engine's new datetime field type (with the same data we already put into the existing public_timestamp Unix timestamp integer field).

(The field has already been added to the Discovery Engine datastore schema in alphagov/search-v2-infrastructure#275)

This allows us to use Discovery Engine's new `datetime` field type (with
the same data we already put into the existing `public_timestamp` Unix
timestamp integer field).

(The field has already been added to the Discovery Engine datastore
schema in alphagov/search-v2-infrastructure#275)
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change. 🌮

Will the public_timestamp field be removed?

@csutter
Copy link
Contributor Author

csutter commented May 16, 2024

Will the public_timestamp field be removed?

Eventually, maybe...

We'll double drive this until a full sync has run and we've replaced usage of public_timestamp with this new field.

Then, the problem is that Vertex Discovery Engine doesn't allow for destructive schema changes yet (such as removing an existing field). Implementing that isn't a big priority for them at the moment (as we can simply choose not to use the field and leave it there without any impact). Hopefully at some point in the future we'll have the ability to do a bigger cleanup as there are other fields in the schema too that we're not using anymore! ❌

@csutter csutter merged commit 6b1f20a into main May 16, 2024
8 checks passed
@csutter csutter deleted the public-ts-datetime branch May 16, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants