Updated the base version from bullseye 3.9-slim-bullseye to bookworm 3.9.18-slim-bookworm #775
Conversation
Modified dependencies versions
The new version of Ghostscript (upgraded in the previous commit) has changed the PDF interpreter (https://www.ghostscript.com/blog/pdfi.html). This breaks the code by causing fonts not to be embedded. This change passes a command line flag to Ghostcript to tell it to use the original interpreter. While we will need to upgrade the interpreter too, this is best done as its own piece of work when we're not also changing the base image and other dependencies.
|
Latest local test run: |
|
Nice one on getting the image building and the unit tests passing! There is some guidance in the template preview repo for how to do some basic visual regression testing. Would you be able to do have a go at that please? We don't do it often so may be worth finding a pair https://github.com/alphagov/notifications-template-preview/blob/main/docs/visual-testing.md There is also some useful guidance in that docs directory for how to deploy it as well to reduce the chance of problems |
|
That visual testing has a |
|
I've updated the commit which was being used to test (#777) so we can take another look now |
|
@robbrazil how are we getting on with this? |
|
We didn't make much progress and were struggling to figure out testing the changes and figuring out what differences were acceptable. For that reason we moved it into blocked on our trello board and we need to figure out the next steps... |
Modified dependencies versions