Selectively silence deprecations and fix missed warnings #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 3738efa |
We want to be able to use `silenceDeprecations`, which is only available in 1.74.0 and above [1]. [1]: https://sass-lang.com/documentation/js-api/interfaces/options/#silenceDeprecations
Silencing all logs means that we may miss: - any deprecations from Sass that we can fix now without breaking support for LibSass and Ruby Sass - tests that need updating because of our own deprecations Instead we can use the new `silenceDeprecations` feature introduced in Sass 1.74.0 and silence just the deprecations we know we can’t do anything about.
We need to pass `sassConfig` which configures Sass to use the mockWarnFunction for the expected warnings, silencing them.
36degrees
force-pushed
the
better-silenced-deprecations
branch
from
23f202b
to
3738efa
Compare
| @@ -18,7 +18,7 @@ const sassPaths = [ | |||
| async function compileSassFile(path, options = {}) { | |||
| return compileAsync(path, { | |||
| loadPaths: sassPaths, | |||
| logger: Logger.silent, | |||
| silenceDeprecations: ['slash-div'], | |||
There was a problem hiding this comment.
@36degrees Really glad this is out now, I had my eyes on this 🙌
Remember I had to write my own logger for Sass builds? Can probably whip that out now too
It's suppressing these two currently:
suppressed: [
'Using / for division is deprecated and will be removed in Dart Sass 2.0.0.',
'Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.'
]There was a problem hiding this comment.
Thanks for the heads up! 🙌🏻
I'll raise an issue as something to do in a follow up PR.
2 tasks
romaricpascal
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silencing all logs means that we may miss:
allentrypoints!)Instead we can use the new
silenceDeprecationsoption introduced in Sass 1.74.0 and silence just the deprecations we know we can’t do anything about.Fix the deprecation warnings that we can now see 🎉