Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update basic docker guidance #2929

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Update basic docker guidance #2929

wants to merge 4 commits into from

Commits on Jan 19, 2021

  1. Update ruby docker version to 2.7.2 

    This is the version content publisher currently targets, we should build using the same version here
    @huwd
    huwd committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    25a9c41 View commit details
    Browse the repository at this point in the history

  2. Small improvements to intro to Docker 

    Rather than have to keep this up to date with the latest docker version
or risk a user being confused if their terminal shows a different
version to whats in the docs, I've replaced these with placeholders and
a link to find the latest version of Docker Engine.

Add a note about how to exit the docker terminal

Most users will likely have the CLI-fu to do this, but on the off chance
a user might feel "trapped" inside this shell-within-a-shell, I've added
a short note about the `exit` command.
    @huwd
    huwd committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    19c6b6e View commit details
    Browse the repository at this point in the history

  3. Fix postgres in docker now requires a POSTGRES_PASSWORD

    @huwd
    huwd committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    4f2f909 View commit details
    Browse the repository at this point in the history

  4. Add clarifying comment to explain container ID and the unusual name

    @huwd
    huwd committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    6a69f33 View commit details
    Browse the repository at this point in the history