Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix: Lowercase m for Minimum #3498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankieroberto
Copy link
Contributor

Spotted this minor inconsistency.

Spotted this minor inconsistency.
Copy link

netlify bot commented Jan 30, 2024

You can preview this change here:

Built without sensitive environment variables

Name Link
🔨 Latest commit a32505a
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/65b914839f8c1c0008b7db61
😎 Deploy Preview https://deploy-preview-3498--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy. Thanks Frankie! Will wait for a 2nd approval so that we're following due process.

@querkmachine
Copy link
Member

Now I'm actually looking I can see a few places where we've upper-capped "Minimum", like the colours page, password pattern and help users create accounts.

Not to say this PR should blam them all, but probably worth a systematic look at the content now that this has been brought up.

@frankieroberto
Copy link
Contributor Author

(just spotted this whilst watching the show-and-tell! 🙌 )

@36degrees
Copy link
Member

Just a thought – WCAG seems to treat the different success criterion as proper nouns and title cases them everywhere in their own guidance. Should we follow suit instead?

It may make it clearer that we're referring to a specific thing rather than e.g the general concept of 'redundant entry'

@36degrees
Copy link
Member

As an alternative option, I've raised another PR which consistently uses proper nouns for the success criteria – #3555

@calvin-lau-sig7
Copy link
Contributor

Thanks all!

Currently I'd stuck with sentence case as we've done here. E.g.:

Focus not obscured (minimum)

Style guide on capitalisation says to "Always use sentence case, even in page titles and service names", which I'd probably put these criteria down as.

@frankieroberto
Copy link
Contributor Author

@calvin-lau-sig7 @owenatgov can you approve the workflow, and then I think this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants