-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fix: Lowercase m for Minimum #3498
base: main
Are you sure you want to change the base?
Conversation
Spotted this minor inconsistency.
✅ You can preview this change here:Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy peasy. Thanks Frankie! Will wait for a 2nd approval so that we're following due process.
Now I'm actually looking I can see a few places where we've upper-capped "Minimum", like the colours page, password pattern and help users create accounts. Not to say this PR should blam them all, but probably worth a systematic look at the content now that this has been brought up. |
(just spotted this whilst watching the show-and-tell! 🙌 ) |
Just a thought – WCAG seems to treat the different success criterion as proper nouns and title cases them everywhere in their own guidance. Should we follow suit instead? It may make it clearer that we're referring to a specific thing rather than e.g the general concept of 'redundant entry' |
As an alternative option, I've raised another PR which consistently uses proper nouns for the success criteria – #3555 |
Thanks all! Currently I'd stuck with sentence case as we've done here. E.g.:
Style guide on capitalisation says to "Always use sentence case, even in page titles and service names", which I'd probably put these criteria down as. |
@calvin-lau-sig7 @owenatgov can you approve the workflow, and then I think this can be merged? |
Spotted this minor inconsistency.