Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Check for broken external links #3174

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

colinrotherham
Copy link
Contributor

Quick spike PR to review broken link output for external links too

We currently use hyperlink --internal and have missed quite a few

@colinrotherham colinrotherham changed the base branch from main to check-links-reporter September 25, 2023 16:44
@colinrotherham colinrotherham linked an issue Sep 25, 2023 that may be closed by this pull request
6 tasks
@netlify
Copy link

netlify bot commented Sep 25, 2023

You can preview this change here:

Name Link
🔨 Latest commit 39a7706
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/657c79dc42886d0008f701e6
😎 Deploy Preview https://deploy-preview-3174--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenjmesser
Copy link
Contributor

stevenjmesser commented Sep 25, 2023

Can you add a description (on here and the linked issue) for what this does and any processes that would need to be created or changed as a result? Should help with giving a fuller review, rather than just a technical review. Ta!

@colinrotherham colinrotherham force-pushed the check-links-reporter branch 2 times, most recently from 24f69c3 to e4b596e Compare September 25, 2023 16:56
@colinrotherham
Copy link
Contributor Author

colinrotherham commented Sep 25, 2023

Can you add a description (on here and the linked issue) for what this does and any processes that would need to be created or changed as a result? Should help with giving a fuller review, rather than just a technical review. Ta!

@stevenjmesser No review required for this one, just wanting to look at the broken link check output

@colinrotherham colinrotherham force-pushed the check-links-reporter branch 2 times, most recently from ab51791 to 0e0f7f5 Compare September 28, 2023 12:02
@colinrotherham colinrotherham force-pushed the check-links-reporter branch 2 times, most recently from 1ff4d02 to f68a012 Compare September 29, 2023 16:02
Base automatically changed from check-links-reporter to main September 29, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve our broken link checking tests
2 participants